1342291 - error: 'mRustTestMode' was not declared in this scope

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

trunk bustage on linux:

In file included from Unified_cpp_media_libstagefright0.cpp:74:0:
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp: In member function 'bool mp4_demuxer::MP4Metadata::ReadTrackIndex(FallibleTArray<mp4_demuxer::Index::Indice>&, mozilla::TrackID)':
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:369:7: error: 'mRustTestMode' was not declared in this scope
   if (mRustTestMode && ret && mRust) {
       ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:369:31: error: 'mRust' was not declared in this scope
   if (mRustTestMode && ret && mRust) {
                               ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:370:5: error: 'mp4parse_byte_data' was not declared in this scope
     mp4parse_byte_data data = {};
     ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:371:44: error: 'data' was not declared in this scope
     bool rustRet = mRust->ReadTrackIndice(&data, aTrackID);
                                            ^
In file included from Unified_cpp_media_libstagefright0.cpp:74:0:
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:373:103: error: template argument 1 is invalid
     MOZ_DIAGNOSTIC_ASSERT(data.length == aDest.Length());
                                                                                                       ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:375:129: error: template argument 1 is invalid
       MOZ_DIAGNOSTIC_ASSERT(data.indices[i].start_offset == aDest[i].start_offset);
                                                                                                                                 ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:376:125: error: template argument 1 is invalid
       MOZ_DIAGNOSTIC_ASSERT(data.indices[i].end_offset == aDest[i].end_offset);
                                                                                                                             ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:377:139: error: template argument 1 is invalid
       MOZ_DIAGNOSTIC_ASSERT(data.indices[i].start_composition == aDest[i].start_composition);
                                                                                                                                           ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:378:135: error: template argument 1 is invalid
       MOZ_DIAGNOSTIC_ASSERT(data.indices[i].end_composition == aDest[i].end_composition);
                                                                                                                                       ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:379:129: error: template argument 1 is invalid
       MOZ_DIAGNOSTIC_ASSERT(data.indices[i].start_decode == aDest[i].start_decode);
                                                                                                                                 ^
/builds/slave/c-cen-t-lnx/build/mozilla/media/libstagefright/binding/MP4Metadata.cpp:380:113: error: template argument 1 is invalid
       MOZ_DIAGNOSTIC_ASSERT(data.indices[i].sync == aDest[i].sync);
                                                                                                                 ^
/builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.9.4/../../../../x86_64-unknown-linux-gnu/bin/as: /lib64/libz.so.1: no version information available (required by /builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.9.4/../../../../x86_64-unknown-linux-gnu/bin/as)
In file included from UnifiedProtocols16.cpp:137:0:
PPresentationChild.cpp: In member function 'virtual mozilla::ipc::HasResultCodes::Result mozilla::dom::PPresentationChild::OnMessageReceived(const Message&)':
PPresentationChild.cpp:654:46: warning: 'handle__.mozilla::ipc::ActorHandle::mId' may be used uninitialized in this function [-Wmaybe-uninitialized]
             RegisterID(actor, (handle__).mId);
                                              ^
make[4]: *** [Unified_cpp_media_libstagefright0.o] Error 1
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/media/libstagefright'
make[3]: *** [media/libstagefright/target] Error 2
make[3]: *** Waiting for unfinished jobs....

Comment 1

[Edmund Wong (:ewong)]

Fallout from bug 1331330 I believe.

Comment 2

[Edmund Wong (:ewong)]

or maybe bug 1219530?

Comment 3

[Edmund Wong (:ewong)]

Attachment: proposed patch

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8840743 [details] [diff] [review]
proposed patch

stealing review r=me a=bustage fix

Comment 5

[Edmund Wong (:ewong)]

https://hg.mozilla.org/comm-central/rev/27b56804b7e3fde261ad910b1866e78736621442
Bug 1342291 - Add MOZ_RUST_MP4PARSE=1 to confvars.sh. r=frg a=ewong

Comment 6

[Jorg K (CEST = GMT+2)]

MOZ_RUST_MP4PARSE removed again here:
https://hg.mozilla.org/comm-central/rev/84e007d226a212a9e79d93fb644aa6a7e57d60a7