Closed Bug 1342299 Opened 7 years ago Closed 5 years ago

Intermittent browser/base/content/test/general/browser_tab_close_dependent_window.js | Opened tab should also have closed - Got false, expected true

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: intermittent-failure)

This is failing multiple times per push on Beta at the moment. Gijs, do you know anybody who might have some cycles to look at this?
Component: General → Tabbed Browser
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #21)
> This is failing multiple times per push on Beta at the moment. Gijs, do you
> know anybody who might have some cycles to look at this?

Someone with cycles, eh... I'll see if it can be me tomorrow or on Monday. I don't really have better ideas right now.

To be fair, as far as I can tell the thing the test is trying to test is OK, but somehow we don't think the tab is gone even though the entire window is gone (because the test doesn't time out, and there's only 1 window on the screenshots, afaict). So maybe it's just missing waiting for the other tab to be removed or something before checking that it's really gone. But I need to get set up to reproduce this to verify that stuff, and I haven't been able to make time today to get that done.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2c726518f67
browser_tab_close_dependent_window.js should wait for the tab to have gone away, rs=firebot,test-only
I can't repro this locally on either debug or opt, even with --verify, and it's become less frequent, but I'm reasonably hopeful my addition to the test will help sort this out. I'm marking leave-open so we can continue to monitor the test.

Because I'm on PTO, and because the frequency has gone down, per conversation on IRC I'm deferring to Ryan to uplift to beta if this does address the intermittent orange. :-)
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(ryanvm)
Keywords: leave-open
Huh, this basically went away on the 11th after it merged around, but now there's been some new instances again starting on the 17th?!
Flags: needinfo?(ryanvm)
Yeah, this is still hitting on Beta.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #28)
> Huh, this basically went away on the 11th after it merged around, but now
> there's been some new instances again starting on the 17th?!

Pixies, I swear.

I just got back from 3 weeks of PTO, and I will try to look at this again when I dig out of my backlog of 2000-odd emails. Frequency seems at least a little reduced compared to 2 months back, though how much of that is this patch, no idea...
Flags: needinfo?(gijskruitbosch+bugs)

I guess we fixed it

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: leave-open
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.