Closed Bug 1342301 Opened 6 years ago Closed 6 years ago

Split out an "optimize" key from configure-args

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

Split out an "optimize" key from configure-args
9.45 KB, patch
arai
: review+
Details | Diff | Splinter Review 
(from bug 1340850)

I'm not sure if you filed this yet, but I put together a patch for just the optimize portion already so I guess I should file a bug before you have to redo the work.
Comment on attachment 8840726 [details] [diff] [review]
Split out an "optimize" key from configure-args

Review of attachment 8840726 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :D

::: js/src/devtools/automation/variants/dtrace
@@ +1,2 @@
>  {
> +    "configure-args": "--enable-debug --enable-dtrace --enable-debug-symbols"

it needs trailing ","

@@ +1,3 @@
>  {
> +    "configure-args": "--enable-debug --enable-dtrace --enable-debug-symbols"
> +    "optimize": true,

it doesn't need trailing ","
Attachment #8840726 - Flags: review?(arai.unmht) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fbc09f6c49a
Split out an "optimize" key from configure-args, r=arai
https://hg.mozilla.org/mozilla-central/rev/3fbc09f6c49a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
See Also: → 1342634
You need to log in before you can comment on or make changes to this bug.