1342301 - Split out an "optimize" key from configure-args

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

(from bug 1340850)

I'm not sure if you filed this yet, but I put together a patch for just the optimize portion already so I guess I should file a bug before you have to redo the work.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Split out an "optimize" key from configure-args

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8840726 [details] [diff] [review]
Split out an "optimize" key from configure-args

Review of attachment 8840726 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :D

::: js/src/devtools/automation/variants/dtrace
@@ +1,2 @@
>  {
> +    "configure-args": "--enable-debug --enable-dtrace --enable-debug-symbols"

it needs trailing ","

@@ +1,3 @@
>  {
> +    "configure-args": "--enable-debug --enable-dtrace --enable-debug-symbols"
> +    "optimize": true,

it doesn't need trailing ","

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fbc09f6c49a
Split out an "optimize" key from configure-args, r=arai

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3fbc09f6c49a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/863e3936dbea

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/e640e758a7cd