Closed
Bug 1342302
Opened 6 years ago
Closed 6 years ago
Fine tune nsCSSRendering::PaintStyleImageLayerWithSC & SetupImageLayerClip
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: u459114, Assigned: u459114)
References
Details
Attachments
(4 files)
Reduce the complexity inside this funciton
1. ImageLayerClipState::mHasRoundedCorners can be true only if ImageLayerClipState::mClippedRadii is not empty 2. The last parameter of SetupImageLayerClip is verbose.
Summary: Fine tune nsCSSRendering::PaintStyleImageLayerWithSC → Fine tune nsCSSRendering::PaintStyleImageLayerWithSC & SetupImageLayerClip
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Attachment #8840777 -
Flags: review?(mstange)
Attachment #8840778 -
Flags: review?(mstange)
Attachment #8840779 -
Flags: review?(mstange)
Attachment #8840780 -
Flags: review?(mstange)
|
||
Comment 12•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8840777 [details] Bug 1342302 - Part 1. Implement RectCornerRadii::IsEmpty. https://reviewboard.mozilla.org/r/115204/#review116758
Attachment #8840777 -
Flags: review?(mstange) → review+
|
|
||
Comment 13•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8840778 [details] Bug 1342302 - Part 2. Implement ImageLayerClipState::IsValid. https://reviewboard.mozilla.org/r/115206/#review116760
Attachment #8840778 -
Flags: review?(mstange) → review+
|
|
||
Comment 14•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8840779 [details] Bug 1342302 - Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx. https://reviewboard.mozilla.org/r/115208/#review116764 ::: layout/painting/nsCSSRendering.h:582 (Diff revision 3) > - nsRect mDirtyRect; > - gfxRect mDirtyRectGfx; > + nsRect mDirtyRectInAppUnit; > + gfxRect mDirtyRectInDevUnit; I would prefer the names mDirtyRectInAppUnits and mDirtyRectInDevPx.
Attachment #8840779 -
Flags: review?(mstange) → review+
|
|
||
Comment 15•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8840780 [details] Bug 1342302 - Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC. https://reviewboard.mozilla.org/r/115210/#review116864
Attachment #8840780 -
Flags: review?(mstange) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 20•6 years ago
|
||
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/14fd552c865b Part 1. Implement RectCornerRadii::IsEmpty. r=mstange https://hg.mozilla.org/integration/autoland/rev/f4ac43e3f67d Part 2. Implement ImageLayerClipState::IsValid. r=mstange https://hg.mozilla.org/integration/autoland/rev/a1deec7b451a Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx. r=mstange https://hg.mozilla.org/integration/autoland/rev/1b8511b2ca4c Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC. r=mstange
|
||
Comment 21•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/14fd552c865b https://hg.mozilla.org/mozilla-central/rev/f4ac43e3f67d https://hg.mozilla.org/mozilla-central/rev/a1deec7b451a https://hg.mozilla.org/mozilla-central/rev/1b8511b2ca4c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•5 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•