1342302 - Fine tune nsCSSRendering::PaintStyleImageLayerWithSC & SetupImageLayerClip

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[u459114]

Reduce the complexity inside this funciton

Comment 1

[u459114]

1. ImageLayerClipState::mHasRoundedCorners can be true only if ImageLayerClipState::mClippedRadii is not empty

2. The last parameter of SetupImageLayerClip is verbose.

Comment 2

[u459114]

Attachment: Bug 1342302 - Part 1. Implement RectCornerRadii::IsEmpty.

Review commit: https://reviewboard.mozilla.org/r/115204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115204/

Comment 3

[u459114]

Attachment: Bug 1342302 - Part 2. Implement ImageLayerClipState::IsValid.

Review commit: https://reviewboard.mozilla.org/r/115206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115206/

Comment 4

[u459114]

Attachment: Bug 1342302 - Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx.

Review commit: https://reviewboard.mozilla.org/r/115208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115208/

Comment 5

[u459114]

Attachment: Bug 1342302 - Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC.

Review commit: https://reviewboard.mozilla.org/r/115210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115210/

Comment 6

[u459114]

Comment on attachment 8840778 [details]
Bug 1342302 - Part 2. Implement ImageLayerClipState::IsValid.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115206/diff/1-2/

Comment 7

[u459114]

Comment on attachment 8840779 [details]
Bug 1342302 - Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115208/diff/1-2/

Comment 8

[u459114]

Comment on attachment 8840780 [details]
Bug 1342302 - Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115210/diff/1-2/

Comment 9

[u459114]

Comment on attachment 8840778 [details]
Bug 1342302 - Part 2. Implement ImageLayerClipState::IsValid.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115206/diff/2-3/

Comment 10

[u459114]

Comment on attachment 8840779 [details]
Bug 1342302 - Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115208/diff/2-3/

Comment 11

[u459114]

Comment on attachment 8840780 [details]
Bug 1342302 - Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115210/diff/2-3/

Comment 12

[Markus Stange [:mstange]]

Comment on attachment 8840777 [details]
Bug 1342302 - Part 1. Implement RectCornerRadii::IsEmpty.

https://reviewboard.mozilla.org/r/115204/#review116758

Comment 13

[Markus Stange [:mstange]]

Comment on attachment 8840778 [details]
Bug 1342302 - Part 2. Implement ImageLayerClipState::IsValid.

https://reviewboard.mozilla.org/r/115206/#review116760

Comment 14

[Markus Stange [:mstange]]

Comment on attachment 8840779 [details]
Bug 1342302 - Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx.

https://reviewboard.mozilla.org/r/115208/#review116764

::: layout/painting/nsCSSRendering.h:582
(Diff revision 3)
> -    nsRect mDirtyRect;
> -    gfxRect mDirtyRectGfx;
> +    nsRect mDirtyRectInAppUnit;
> +    gfxRect mDirtyRectInDevUnit;

I would prefer the names mDirtyRectInAppUnits and mDirtyRectInDevPx.

Comment 15

[Markus Stange [:mstange]]

Comment on attachment 8840780 [details]
Bug 1342302 - Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC.

https://reviewboard.mozilla.org/r/115210/#review116864

Comment 16

[u459114]

Comment on attachment 8840777 [details]
Bug 1342302 - Part 1. Implement RectCornerRadii::IsEmpty.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115204/diff/1-2/

Comment 17

[u459114]

Comment on attachment 8840778 [details]
Bug 1342302 - Part 2. Implement ImageLayerClipState::IsValid.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115206/diff/3-4/

Comment 18

[u459114]

Comment on attachment 8840779 [details]
Bug 1342302 - Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115208/diff/3-4/

Comment 19

[u459114]

Comment on attachment 8840780 [details]
Bug 1342302 - Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115210/diff/3-4/

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14fd552c865b
Part 1. Implement RectCornerRadii::IsEmpty. r=mstange
https://hg.mozilla.org/integration/autoland/rev/f4ac43e3f67d
Part 2. Implement ImageLayerClipState::IsValid. r=mstange
https://hg.mozilla.org/integration/autoland/rev/a1deec7b451a
Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx. r=mstange
https://hg.mozilla.org/integration/autoland/rev/1b8511b2ca4c
Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC. r=mstange

Comment 21

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/14fd552c865b
https://hg.mozilla.org/mozilla-central/rev/f4ac43e3f67d
https://hg.mozilla.org/mozilla-central/rev/a1deec7b451a
https://hg.mozilla.org/mozilla-central/rev/1b8511b2ca4c