Closed Bug 1342328 Opened 7 years ago Closed 7 years ago

Intermittent tests/jit-test/jit-test/tests/ion/dce-with-rinstructions.js | Unknown (code -11, args "")

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: nbp)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

IonMonkey dce-with-rinstructions.js test: Prevent compilation of the top-level loop.
1.99 KB, patch
tcampbell
: review+
Details | Diff | Splinter Review
Flags: needinfo?(nicolas.b.pierron)
this is osx opt only, not a high failure rate, but creeping up, 20 times in the last week, no easy sign to see of where the increase started- could just be random luck
I am able to reproduce a similar issue while running on Linux with "rr record -h".
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
These test cases are supposed to work as follow:
 - They run a few number of times with a single variant of the same
   function, and inline the only known variant of it, which contains
      "return false;"

 - Then Unreachable Code Elimination removes of the testing branch, and the
   usage of the variables from it.

 - The function assertRecoveredOnBailout then asserts
   that the first input is recovered as expected, when it is being encoded.

The problem was that by compiling the top-level for-loop, we prevented the
inlining of the uceFault* functions, which thus prevent the removal ofthe
testing branches, and the removal of the uses, thus the failure of the
assertRecoveredOnBailout functions as recover instructions.

This patch adds "with({}){}" no-op statement in the top-level for loop, which has
the side-effect of preventing the compilation of the for loop with IonMonkey.
Attachment #8866414 - Flags: review?(tcampbell)
Flags: needinfo?(nicolas.b.pierron)
Comment on attachment 8866414 [details] [diff] [review]
IonMonkey dce-with-rinstructions.js test: Prevent compilation of the top-level loop.

Review of attachment 8866414 [details] [diff] [review]:
-----------------------------------------------------------------

In the future it would be nice to have something more robust than |with({}){}|. Otherwise, looks good.
Attachment #8866414 - Flags: review?(tcampbell) → review+
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b73d9e993d96
IonMonkey dce-with-rinstructions.js test: Prevent compilation of the top-level loop. r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/b73d9e993d96
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: