1342339 - Remove compile warning from 1340446.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alfredo Yang (:alfredo)]

Fix for "warning: taking the absolute value of unsigned type 'unsigned long long' has no effect [-Wabsolute-value]".

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: Bug 1342339 - remove compile warning from bug 1340446.

Review commit: https://reviewboard.mozilla.org/r/115196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115196/

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8840772 [details]
Bug 1342339 - remove compile warning from bug 1340446.

https://reviewboard.mozilla.org/r/115196/#review116680

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8840772 [details]
Bug 1342339 - remove compile warning from bug 1340446.

https://reviewboard.mozilla.org/r/115196/#review117668

Thank you for taking care of this. A fly-by suggestion:

::: media/libstagefright/binding/MP4Metadata.cpp:359
(Diff revision 1)
> -      MOZ_DIAGNOSTIC_ASSERT(llabs(data.indices[i].start_composition - aDest[i].start_composition) <= 1);
> -      MOZ_DIAGNOSTIC_ASSERT(llabs(data.indices[i].end_composition - aDest[i].end_composition) <= 1);
> -      MOZ_DIAGNOSTIC_ASSERT(llabs(data.indices[i].start_decode - aDest[i].start_decode) <= 1);
> +      MOZ_DIAGNOSTIC_ASSERT(llabs((int64_t)(data.indices[i].start_composition - aDest[i].start_composition)) <= 1);
> +      MOZ_DIAGNOSTIC_ASSERT(llabs((int64_t)(data.indices[i].end_composition - aDest[i].end_composition)) <= 1);
> +      MOZ_DIAGNOSTIC_ASSERT(llabs((int64_t)(data.indices[i].start_decode - aDest[i].start_decode)) <= 1);

May I suggest you don't use C-style casts?
The easiest would be a C++ constructor-style cast, just remove the parentheses around 'int64_t'. ;-)

Comment 5

[Alfredo Yang (:alfredo)]

Attachment: Bug 1342339 - remove compile warning from bug 1340446.

Review commit: https://reviewboard.mozilla.org/r/116142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116142/

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8842277 [details]
Bug 1342339 - remove compile warning from bug 1340446.

https://reviewboard.mozilla.org/r/116142/#review117708

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2da1219f2347
remove compile warning from bug 1340446. r=kinetik

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2da1219f2347