Closed
Bug 1342339
Opened 7 years ago
Closed 7 years ago
Remove compile warning from 1340446.
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: ayang, Assigned: ayang)
References
Details
Attachments
(1 file, 1 obsolete file)
Fix for "warning: taking the absolute value of unsigned type 'unsigned long long' has no effect [-Wabsolute-value]".
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ayang
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8840772 [details] Bug 1342339 - remove compile warning from bug 1340446. https://reviewboard.mozilla.org/r/115196/#review116680
Attachment #8840772 -
Flags: review?(kinetik) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8840772 [details] Bug 1342339 - remove compile warning from bug 1340446. https://reviewboard.mozilla.org/r/115196/#review117668 Thank you for taking care of this. A fly-by suggestion: ::: media/libstagefright/binding/MP4Metadata.cpp:359 (Diff revision 1) > - MOZ_DIAGNOSTIC_ASSERT(llabs(data.indices[i].start_composition - aDest[i].start_composition) <= 1); > - MOZ_DIAGNOSTIC_ASSERT(llabs(data.indices[i].end_composition - aDest[i].end_composition) <= 1); > - MOZ_DIAGNOSTIC_ASSERT(llabs(data.indices[i].start_decode - aDest[i].start_decode) <= 1); > + MOZ_DIAGNOSTIC_ASSERT(llabs((int64_t)(data.indices[i].start_composition - aDest[i].start_composition)) <= 1); > + MOZ_DIAGNOSTIC_ASSERT(llabs((int64_t)(data.indices[i].end_composition - aDest[i].end_composition)) <= 1); > + MOZ_DIAGNOSTIC_ASSERT(llabs((int64_t)(data.indices[i].start_decode - aDest[i].start_decode)) <= 1); May I suggest you don't use C-style casts? The easiest would be a C++ constructor-style cast, just remove the parentheses around 'int64_t'. ;-)
Attachment #8840772 -
Flags: review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8840772 -
Attachment is obsolete: true
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8842277 [details] Bug 1342339 - remove compile warning from bug 1340446. https://reviewboard.mozilla.org/r/116142/#review117708
Attachment #8842277 -
Flags: review?(kinetik) → review+
Pushed by ayang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2da1219f2347 remove compile warning from bug 1340446. r=kinetik
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2da1219f2347
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•