Crash in SharedLibraryInfo::GetInfoForSelf

RESOLVED FIXED in Firefox 54

Status

()

defect
--
critical
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: calixte, Assigned: marco)

Tracking

(Blocks 1 bug, {crash})

unspecified
mozilla54
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 unaffected, firefox53 unaffected, firefox54 fixed)

Details

(Whiteboard: [clouseau], crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is 
report bp-ae17fa20-fb35-4fcb-8f51-23cc52170223.
=============================================================

There is 1 crash on nightly with buildid 20170222030329. In analyzing the backtrace, this regression may have been introduced by patch [1] to fix bug 1330833.

[1] https://hg.mozilla.org/mozilla-central/rev?node=8fc28f2d52d93245ed802f23c15c16290a7c22cc
Flags: needinfo?(mcastelluccio)
Component: Telemetry → Gecko Profiler
Product: Toolkit → Core
Posted patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Flags: needinfo?(mcastelluccio)
Attachment #8840795 - Flags: review?(mstange)
Comment on attachment 8840795 [details] [diff] [review]
Patch

Review of attachment 8840795 [details] [diff] [review]:
-----------------------------------------------------------------

Yikes, sorry for missing that.
Attachment #8840795 - Flags: review?(mstange) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aab0b3a45dae
Fix out-of-bounds access in GetInfoForSelf. r=mstange
(In reply to Markus Stange [:mstange] from comment #2)
> Comment on attachment 8840795 [details] [diff] [review]
> Patch
> 
> Review of attachment 8840795 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Yikes, sorry for missing that.

My mistake, I copied the code from another file that I had written in the past (https://dxr.mozilla.org/mozilla-central/rev/5069348353f8fc1121e632e3208da33900627214/dom/media/platforms/wmf/WMFVideoMFTManager.cpp#234) where I actually needed the `<=`, but then forgot to change it to `<` :)
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f4c2db6fcf5
Backout mistakenly pushed patch and push the actual fix. r=me
https://hg.mozilla.org/mozilla-central/rev/aab0b3a45dae
https://hg.mozilla.org/mozilla-central/rev/2f4c2db6fcf5
Landed 15 hours ago.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Whiteboard: [clouseau]
You need to log in before you can comment on or make changes to this bug.