Closed
Bug 1342349
Opened 7 years ago
Closed 7 years ago
Crash in SharedLibraryInfo::GetInfoForSelf
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
People
(Reporter: calixte, Assigned: marco)
References
(Blocks 1 open bug)
Details
(Keywords: crash, Whiteboard: [clouseau])
Crash Data
Attachments
(1 file)
1.07 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-ae17fa20-fb35-4fcb-8f51-23cc52170223. ============================================================= There is 1 crash on nightly with buildid 20170222030329. In analyzing the backtrace, this regression may have been introduced by patch [1] to fix bug 1330833. [1] https://hg.mozilla.org/mozilla-central/rev?node=8fc28f2d52d93245ed802f23c15c16290a7c22cc
Flags: needinfo?(mcastelluccio)
Assignee | ||
Updated•7 years ago
|
Component: Telemetry → Gecko Profiler
Product: Toolkit → Core
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Flags: needinfo?(mcastelluccio)
Attachment #8840795 -
Flags: review?(mstange)
Comment 2•7 years ago
|
||
Comment on attachment 8840795 [details] [diff] [review] Patch Review of attachment 8840795 [details] [diff] [review]: ----------------------------------------------------------------- Yikes, sorry for missing that.
Attachment #8840795 -
Flags: review?(mstange) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aab0b3a45dae Fix out-of-bounds access in GetInfoForSelf. r=mstange
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #2) > Comment on attachment 8840795 [details] [diff] [review] > Patch > > Review of attachment 8840795 [details] [diff] [review]: > ----------------------------------------------------------------- > > Yikes, sorry for missing that. My mistake, I copied the code from another file that I had written in the past (https://dxr.mozilla.org/mozilla-central/rev/5069348353f8fc1121e632e3208da33900627214/dom/media/platforms/wmf/WMFVideoMFTManager.cpp#234) where I actually needed the `<=`, but then forgot to change it to `<` :)
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2f4c2db6fcf5 Backout mistakenly pushed patch and push the actual fix. r=me
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aab0b3a45dae https://hg.mozilla.org/mozilla-central/rev/2f4c2db6fcf5 Landed 15 hours ago.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
Updated•7 years ago
|
Whiteboard: [clouseau]
You need to log in
before you can comment on or make changes to this bug.
Description
•