1342370 - Links in in-content UI pages have two focus rings

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

Links in in-content UI pages (such as "Learn more" in about:preferences#content) currently have two focus rings.

One from here:
https://hg.mozilla.org/mozilla-central/annotate/5069348353f8fc1121e632e3208da33900627214/toolkit/themes/linux/global/global.css#l282

And one from here:
https://hg.mozilla.org/mozilla-central/annotate/5069348353f8fc1121e632e3208da33900627214/toolkit/themes/linux/global/in-content/common.css#l93

We should remove the latter.

Comment 1

[joshua.d.horwitz]

Attachment: patch.diff

Comment 2

[Stefan [:stefanh]]

Thanks for the patch. You need to ask for review - just click the "details" link for the attachment and then set the review flag to "?" and enter [e-mail] (who's also mentoring this).

Comment 3

[joshua.d.horwitz]

Thank you very much, done!

Comment 4

[Stefan [:stefanh]]

Comment on attachment 8841233 [details] [diff] [review]
patch.diff

I just looked at the patch, and to make a long story short: global.css handle styles appearing everywhere in the ui, but we just have a problem with the in-content ui pages. In other words, you want to remove the style rule in toolkit/themes/linux/global/in-content/common.css instead.

Comment 5

[joshua.d.horwitz]

Thank you, I have updated the patch.

Comment 6

[joshua.d.horwitz]

Attachment: patch.diff

Updated to remove from common.css instead of global.css

Comment 7

[Stefan [:stefanh]]

Comment on attachment 8841279 [details] [diff] [review]
patch.diff

diff --git a/toolkit/themes/linux/global/global.css b/toolkit/themes/linux/global/global.css
--- a/toolkit/themes/linux/global/global.css
+++ b/toolkit/themes/linux/global/global.css

Hmm, wrong patch uploaded?

Comment 8

[joshua.d.horwitz]

Attachment: patch.diff

Comment 9

[joshua.d.horwitz]

Sorry about that, added the wrong revision to the patch!  Coming from SVN and Git world.  Thank you for the hel

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8841281 [details] [diff] [review]
patch.diff

You seem to have committed the previous patch where you removed the rule from global.css, and this diff is against that commit so it appears to be adding that rule back. Instead the diff should be against mozilla-central tip and not touch global.css at all.

Comment 11

[Dão Gottwald [:dao]]

Joshua, can you make sense of my previous comment?

Comment 12

[joshua.d.horwitz]

Thank you for the help, how can I rectify this and go back and make this correct change?

Comment 13

[Dão Gottwald [:dao]]

(In reply to joshua.d.horwitz from comment #12)
> Thank you for the help, how can I rectify this and go back and make this
> correct change?

It depends on your hg workflow... How exactly did you create these patches in the first place?

In #introduction there are probably people who can help you with questions about hg too.

Comment 14

[Dão Gottwald [:dao]]

Joshua, do you still want to work on this?

Comment 15

[Ganesh Chaitanya Kale]

(In reply to Dão Gottwald [::dao] from comment #14)
> Joshua, do you still want to work on this?

Hi Dao,

Can I start working on this, If so can assign it to me. I just did a setup of my Firefox with default branch. I would like to have input from you on how to work on the fix.


Regards,
Ganesh

Comment 16

[Ganesh Chaitanya Kale]

Attachment: Fix for the bug in Patch file Bug 1342370_Patch.patch

I have attached the patch with the fix, please review it and let me know if any changes are necessary.

Regards,
Ganesh

Comment 17

[Dão Gottwald [:dao]]

Comment on attachment 8849166 [details] [diff] [review]
Fix for the bug in Patch file Bug 1342370_Patch.patch

Thanks!

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e399a0575a4
Remove focus ring from common.css as its already in global.css. r=dao

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2e399a0575a4