Closed Bug 1342370 Opened 4 years ago Closed 3 years ago

Links in in-content UI pages have two focus rings

Categories

(Toolkit :: Themes, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: dao, Assigned: ganesh2583, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])

Attachments

(1 file, 3 obsolete files)

Attached patch patch.diff (obsolete) — Splinter Review
Thanks for the patch. You need to ask for review - just click the "details" link for the attachment and then set the review flag to "?" and enter dao+bmo@mozilla.com (who's also mentoring this).
Assignee: nobody → joshua.d.horwitz
Status: NEW → ASSIGNED
Attachment #8841233 - Flags: review?(dao+bmo)
Thank you very much, done!
Comment on attachment 8841233 [details] [diff] [review]
patch.diff

I just looked at the patch, and to make a long story short: global.css handle styles appearing everywhere in the ui, but we just have a problem with the in-content ui pages. In other words, you want to remove the style rule in toolkit/themes/linux/global/in-content/common.css instead.
Thank you, I have updated the patch.
Attached patch patch.diff (obsolete) — Splinter Review
Updated to remove from common.css instead of global.css
Attachment #8841233 - Attachment is obsolete: true
Attachment #8841233 - Flags: review?(dao+bmo)
Attachment #8841279 - Flags: review?(dao+bmo)
Comment on attachment 8841279 [details] [diff] [review]
patch.diff

diff --git a/toolkit/themes/linux/global/global.css b/toolkit/themes/linux/global/global.css
--- a/toolkit/themes/linux/global/global.css
+++ b/toolkit/themes/linux/global/global.css

Hmm, wrong patch uploaded?
Attached patch patch.diff (obsolete) — Splinter Review
Attachment #8841279 - Attachment is obsolete: true
Attachment #8841279 - Flags: review?(dao+bmo)
Attachment #8841281 - Flags: review?(dao+bmo)
Sorry about that, added the wrong revision to the patch!  Coming from SVN and Git world.  Thank you for the hel
Comment on attachment 8841281 [details] [diff] [review]
patch.diff

You seem to have committed the previous patch where you removed the rule from global.css, and this diff is against that commit so it appears to be adding that rule back. Instead the diff should be against mozilla-central tip and not touch global.css at all.
Attachment #8841281 - Flags: review?(dao+bmo)
Joshua, can you make sense of my previous comment?
Flags: needinfo?(joshua.d.horwitz)
Thank you for the help, how can I rectify this and go back and make this correct change?
(In reply to joshua.d.horwitz from comment #12)
> Thank you for the help, how can I rectify this and go back and make this
> correct change?

It depends on your hg workflow... How exactly did you create these patches in the first place?

In #introduction there are probably people who can help you with questions about hg too.
Joshua, do you still want to work on this?
Assignee: joshua.d.horwitz → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(joshua.d.horwitz)
Attachment #8841281 - Attachment is obsolete: true
(In reply to Dão Gottwald [::dao] from comment #14)
> Joshua, do you still want to work on this?

Hi Dao,

Can I start working on this, If so can assign it to me. I just did a setup of my Firefox with default branch. I would like to have input from you on how to work on the fix.


Regards,
Ganesh
I have attached the patch with the fix, please review it and let me know if any changes are necessary.

Regards,
Ganesh
Attachment #8849166 - Flags: review?(stefanh)
Attachment #8849166 - Flags: review?(dao+bmo)
Comment on attachment 8849166 [details] [diff] [review]
Fix for the bug in Patch file Bug 1342370_Patch.patch

Thanks!
Attachment #8849166 - Flags: review?(stefanh)
Attachment #8849166 - Flags: review?(dao+bmo)
Attachment #8849166 - Flags: review+
Assignee: nobody → ganesh2583
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e399a0575a4
Remove focus ring from common.css as its already in global.css. r=dao
https://hg.mozilla.org/mozilla-central/rev/2e399a0575a4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.