Closed
Bug 1342394
Opened 7 years ago
Closed 7 years ago
Use standard pad functions in Telemetry JS modules
Categories
(Toolkit :: Telemetry, defect, P4)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: flyingrub, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client] [lang=js])
Attachments
(1 file)
We use some custom padding code in Telemetry: https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcomponents%2Ftelemetry+pad+ext%3Ajs+ext%3Ajsm&redirect=false JS now has standard padding functions though: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padStart https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padEnd We should update the code to use them. To confirm the changes are working, the Telemetry tests can be run with: mach test toolkit/components/telemetry/tests/unit/
padStart & padEnd function are not available with node, should we add the Polyfill to the file ? or perhaps modules/TelemetryUtils.jsm ?
Reporter | ||
Comment 2•7 years ago
|
||
We don't need any polyfills. This code only ships with Firefox and runs on its most recent JS engine.
Comment hidden (mozreview-request) |
Attachment #8842516 -
Flags: review?(gfritzsche)
Comment hidden (mozreview-request) |
Comment on attachment 8842516 [details] Bug 1342394 - Use standard pad functions in Telemetry JS modules https://reviewboard.mozilla.org/r/116322/#review117940
Comment 6•7 years ago
|
||
I would like to help in this. could you give some steps for get start please
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → flyinggrub
Reporter | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8842516 [details] Bug 1342394 - Use standard pad functions in Telemetry JS modules https://reviewboard.mozilla.org/r/116322/#review118936 This looks good, thanks!
Attachment #8842516 -
Flags: review?(gfritzsche) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1406a5dfed25 Use standard pad functions in Telemetry JS modules r=gfritzsche
Keywords: checkin-needed
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1406a5dfed25
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•