Closed Bug 1342398 Opened 3 years ago Closed 3 years ago
Target milestone popup on Bugzilla pages is misplaced
See attached screenshot. All the other comboboxes pop-up right on top of the combobox, but the target milestone one is offset vertically. This seems to happen consistently for me on Aurora 53.0a2 (2017-02-13) nightly. I haven't tried other channels yet.
3 years ago
mozregression bisected down to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1a3194836cb4c3da6ba3a9742a2d25cf26669b55&tochange=90b691bf09f5cc4fe7d0c6445fcf5afa2c34eeee, and then it tried to bisect into fx-team which doesn't exist any more.
Of that range I'm gonna pick bug 430745, it seems the most related to this regression. Can you guys take a look?
The patch in bug 430745 just uses the new API that was implemented by bug 52106 implemented. Redirecting to Neil/mstange since they fixed that bug.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #8843936 - Flags: review?(mstange)
Attachment #8843936 - Flags: review?(mstange) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/4e95d5435e6b incorporate the popup's scroll position into the computation of where the current menuitem is, preventing misplaced popups on Mac, r=mstange
We'll want a fix on aurora and beta. ni to request uplift when ready.
Comment on attachment 8843936 [details] [diff] [review] Incorporate scroll position into position computation Approval Request Comment [Feature/Bug causing the regression]: related to 430745 [User impact if declined]: select dropdowns with many options can be misplaced with respect to their button. Mac only issue. [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: no [Is the change risky?]: no, minor fixup that just adds the correct offset [Why is the change risky/not risky?]: [String changes made/needed]: no
Comment on attachment 8843936 [details] [diff] [review] Incorporate scroll position into position computation Fix a regression related to select dropdowns with many options. Aurora54+ & Beta53+.
Setting qe-verify- based on Neil's assessment on manual testing needs (see Comment 8) and the fact that this fix has automated coverage.
You need to log in before you can comment on or make changes to this bug.