Closed Bug 1342398 Opened 3 years ago Closed 3 years ago

Target milestone popup on Bugzilla pages is misplaced

Categories

(Core :: Widget: Cocoa, defect, P2)

53 Branch
x86_64
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: kats, Assigned: enndeakin)

References

Details

(Keywords: regression, Whiteboard: tpi:+)

Attachments

(2 files)

Attached image Screenshot
See attached screenshot. All the other comboboxes pop-up right on top of the combobox, but the target milestone one is offset vertically. This seems to happen consistently for me on Aurora 53.0a2 (2017-02-13) nightly. I haven't tried other channels yet.
Of that range I'm gonna pick bug 430745, it seems the most related to this regression. Can you guys take a look?
Blocks: 430745
Flags: needinfo?(jaws)
Flags: needinfo?(beachjar)
The patch in bug 430745 just uses the new API that was implemented by bug 52106 implemented. Redirecting to Neil/mstange since they fixed that bug.
Flags: needinfo?(mstange)
Flags: needinfo?(jaws)
Flags: needinfo?(enndeakin)
Flags: needinfo?(beachjar)
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Flags: needinfo?(enndeakin)
Flags: needinfo?(mstange)
Attachment #8843936 - Flags: review?(mstange)
Attachment #8843936 - Flags: review?(mstange) → review+
Priority: -- → P2
Whiteboard: tpi:+
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e95d5435e6b
incorporate the popup's scroll position into the computation of where the current menuitem is, preventing misplaced popups on Mac, r=mstange
https://hg.mozilla.org/mozilla-central/rev/4e95d5435e6b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
We'll want a fix on aurora and beta. ni to request uplift when ready.
Flags: needinfo?(enndeakin)
Comment on attachment 8843936 [details] [diff] [review]
Incorporate scroll position into position computation

Approval Request Comment
[Feature/Bug causing the regression]: related to 430745
[User impact if declined]: select dropdowns with many options can be misplaced with respect to their button. Mac only issue.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: 
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no, minor fixup that just adds the correct offset
[Why is the change risky/not risky?]:
[String changes made/needed]: no
Flags: needinfo?(enndeakin)
Attachment #8843936 - Flags: approval-mozilla-beta?
Attachment #8843936 - Flags: approval-mozilla-aurora?
Comment on attachment 8843936 [details] [diff] [review]
Incorporate scroll position into position computation

Fix a regression related to select dropdowns with many options. Aurora54+ & Beta53+.
Attachment #8843936 - Flags: approval-mozilla-beta?
Attachment #8843936 - Flags: approval-mozilla-beta+
Attachment #8843936 - Flags: approval-mozilla-aurora?
Attachment #8843936 - Flags: approval-mozilla-aurora+
Setting qe-verify- based on Neil's assessment on manual testing needs (see Comment 8) and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.