Closed
Bug 1342402
Opened 8 years ago
Closed 8 years ago
Use optimized GetElement in JSON
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: evilpies, Assigned: evilpies)
References
Details
Attachments
(1 file)
|
4.90 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
By reusing the optimized version of GetElement the time in this micro benchmark goes from 500ms to 430ms. I tried using MOZ_ALWAYS_INLINE, because GetElement was still showing up in perf, but that seems to just have been some kind of misattribution.
Attachment #8840854 -
Flags: review?(jdemooij)
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → evilpies
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8840854 [details] [diff] [review]
Use optimized GetElement in JSON
Review of attachment 8840854 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #8840854 -
Flags: review?(jdemooij) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fe93937af04
Use optimized GetElement in JSON. r=jandem
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•