Closed Bug 1342402 Opened 3 years ago Closed 3 years ago

Use optimized GetElement in JSON

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

By reusing the optimized version of GetElement the time in this micro benchmark goes from 500ms to 430ms. I tried using MOZ_ALWAYS_INLINE, because GetElement was still showing up in perf, but that seems to just have been some kind of misattribution.
Attachment #8840854 - Flags: review?(jdemooij)
Assignee: nobody → evilpies
Comment on attachment 8840854 [details] [diff] [review]
Use optimized GetElement in JSON

Review of attachment 8840854 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8840854 - Flags: review?(jdemooij) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fe93937af04
Use optimized GetElement in JSON. r=jandem
https://hg.mozilla.org/mozilla-central/rev/5fe93937af04
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.