1342441 - Improve the Wrong Sqlite Version message

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect, P1)

Description

[Marco Bonardo [:mak]]

This message doesn't give to the user any kind of solution, it should be improved.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1342441 - Improve the Wrong Sqlite Version message.

Review commit: https://reviewboard.mozilla.org/r/115338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115338/

Comment 2

[Marco Bonardo [:mak]]

Andrew, what do you think? Should we go further?
We could ideally even just MOZ_ASSERT and return nullptr here (would that still crash, I suppose not if the consumer does proper error checking?). My doubt is that even if now we fix whatever causes a wrong init, in the future others may do the same.
Unless we figure out a way to tell "xul.dll is not ready" to any code during an update...

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8840947 [details]
Bug 1342441 - Improve the Wrong Sqlite Version message.

https://reviewboard.mozilla.org/r/115338/#review116816

This is definitely an improvement.

I don't think returning null is likely to help things since I'd expect the result to be that huge swathes of Firefox end up in a broken/degraded state.  (Somewhat reminiscent of what we've seen in bug 1246615.)  I would expect callers to assume they're in shutdown if null is returned and aggressively stop initializing themselves, etc.  System SQLite users may benefit from leaving the error message around too.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbf582404538
Improve the Wrong Sqlite Version message. r=asuth

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cbf582404538

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8840947 [details]
Bug 1342441 - Improve the Wrong Sqlite Version message.

Approval Request Comment
[Feature/Bug causing the regression]: forced crash on startup after a Firefox update. See bug 1341373.
[User impact if declined]: We show a dialog with an unclear string that has no suggested actions for the user
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: It's just changing an hardcoded string
[String changes made/needed]: The string is not localized (this is a rare forced crash due to some still-unresolved issues happening during an update under particular conditions, see bug 1341373)

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8840947 [details]
Bug 1342441 - Improve the Wrong Sqlite Version message.

improve message on sqlite version mismatch, let's take this for 53 (aurora) and 52 (beta/release).

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/66e9dc9f094f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8cc717c3d1c7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/8cc717c3d1c7

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/8cc717c3d1c7