Closed Bug 134248 Opened 22 years ago Closed 22 years ago

Change in nsIIOServices extractUrlPart method: No longer returns start and end offsets of parts

Categories

(SeaMonkey :: Composer, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: cmanske, Assigned: cmanske)

References

Details

(Keywords: regression, Whiteboard: publish)

Attachments

(1 file, 3 obsolete files)

Composer uses nsIIOServices::extractUrlPart() a lot. Interface change has
busted StripUsernamePassword(). We also need to drop out param objects to all
other calls to this.
Attached patch Patch v1 (obsolete) — Splinter Review
Status: NEW → ASSIGNED
Keywords: nsbeta1, regression
Whiteboard: publish
Target Milestone: --- → mozilla1.0
Comment on attachment 76767 [details] [diff] [review]
Patch v1

r=brade
Attachment #76767 - Flags: review+
Attached patch Patch v2 (obsolete) — Splinter Review
Look for ":" in case username is same as password
Attachment #76767 - Attachment is obsolete: true
Attached patch Patch v3 (obsolete) — Splinter Review
Take my time. Get it right.
Attachment #76770 - Attachment is obsolete: true
Attached patch Patch v4Splinter Review
Stupid notepad patch. wrong file last time.
Attachment #76775 - Attachment is obsolete: true
Comment on attachment 76777 [details] [diff] [review]
Patch v4

r=akkana
You might consider putting the GetIoService call inside the if (atIndex > 0),
perhaps even inside the try in that if, since the IOService isn't actually used
otherwise.  (You can have the r= either way, no need to submit another patch
for that if you decide to do it.)
Attachment #76777 - Flags: review+
Comment on attachment 76777 [details] [diff] [review]
Patch v4

sr=kin@netscape.com

I like akk's suggestion to move the GetIOService() call into the try, just
before you use it.
Attachment #76777 - Flags: superreview+
Blocks: 133823
Blocks: 134059
No longer blocks: 134059
Whiteboard: publish → publish, FIX IN HAND, need approval
Comment on attachment 76777 [details] [diff] [review]
Patch v4

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #76777 - Flags: approval+
Whiteboard: publish, FIX IN HAND, need approval → publish, FIX IN HAND, approved
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Whiteboard: publish, FIX IN HAND, approved → publish
Charley, can you verify this bug and mar verified-fixed? thanks..
verified
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: