Closed Bug 1342488 Opened 3 years ago Closed 3 years ago

Run QR test jobs on regular builds, but with the gfx.webrender.enabled pref set to true

Categories

(Core :: Graphics: WebRender, defect, P3)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(4 files)

Once bug 1342450 lands, regular (non-QR) nightly builds will have WebRender built-in, can can run in Super Duper Quantum Mode if the gfx.webrender.enabled pref is set to true.

For automation, this means we should switch our test jobs from running on the QR builds to running on the non-QR builds with the pref set. This will allow us to decommission the "special" QR builds which are no different from the regular builds except for a pref flip.
Dipping my toe in the water here, got crashtests running on a Linux64 build which has webrender built-in but not enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1e7fd5fb5d9197b0e074b77bc01ed66630f4bc5
Comment on attachment 8866919 [details]
Bug 1342488 - Allow enabling webrender with an environment variable.

https://reviewboard.mozilla.org/r/138524/#review141788
Attachment #8866919 - Flags: review?(rhunt) → review+
Comment on attachment 8866920 [details]
Bug 1342488 - Add an option to mozharness to enable WebRender.

https://reviewboard.mozilla.org/r/138526/#review141818

thanks for being complete here.  Is there a need for android at all?
Attachment #8866920 - Flags: review?(jmaher) → review+
Comment on attachment 8866921 [details]
Bug 1342488 - Add a flag in the task to run with webrender, and enable it by default on linux64-qr test platforms.

https://reviewboard.mozilla.org/r/138528/#review142196

::: taskcluster/docs/attributes.rst:163
(Diff revision 1)
> +
> +webrender
> +=========
> +For test suites, this determines if the test runs with WebRender compositing
> +enabled or disabled. If enabled, the build is started with the pref
> +gfx.webrender.enabled set to true.

It doesn't look like you ever actually set a task attribute here -- just an entry in the test description.  I think the implemenetation below is correct, but please remove this documentation for a nonexistent attribute.
Attachment #8866921 - Flags: review?(dustin) → review-
Comment on attachment 8866922 [details]
Bug 1342488 - Run the linux64-qr test platforms using the regular linux64 build platform, and remove the linux64-qr build platform.

https://reviewboard.mozilla.org/r/138530/#review142198
Attachment #8866922 - Flags: review?(dustin) → review+
(In reply to Joel Maher ( :jmaher) from comment #8)
> thanks for being complete here.  Is there a need for android at all?

Not at the moment, no. Eventually we'll want it on android too but probably not this year at least.
(In reply to Dustin J. Mitchell [:dustin] from comment #9)
> It doesn't look like you ever actually set a task attribute here -- just an
> entry in the test description.  I think the implemenetation below is
> correct, but please remove this documentation for a nonexistent attribute.

Ah, sorry about that. I'm not too clear on the different types of properties, and this probably got left in from an earlier version of these patches where it was complaining about missing the attribute in the rst file. I'll update the patch to remove that.
Comment on attachment 8866921 [details]
Bug 1342488 - Add a flag in the task to run with webrender, and enable it by default on linux64-qr test platforms.

https://reviewboard.mozilla.org/r/138528/#review142244
Attachment #8866921 - Flags: review?(dustin) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 89de1cb9f112 -d 942071ef8ff7: rebasing 395553:89de1cb9f112 "Bug 1342488 - Allow enabling webrender with an environment variable. r=rhunt"
rebasing 395554:b4e4a47a9599 "Bug 1342488 - Add an option to mozharness to enable WebRender. r=jmaher"
rebasing 395555:5a20a465568d "Bug 1342488 - Add a flag in the task to run with webrender, and enable it by default on linux64-qr test platforms. r=dustin"
rebasing 395556:afb273d2ab00 "Bug 1342488 - Run the linux64-qr test platforms using the regular linux64 build platform, and remove the linux64-qr build platform. r=dustin" (tip)
merging taskcluster/ci/build/linux.yml
warning: conflicts while merging taskcluster/ci/build/linux.yml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a17c58c2c73d
Allow enabling webrender with an environment variable. r=rhunt
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fcb53b646be
Add an option to mozharness to enable WebRender. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/55ea64942756
Add a flag in the task to run with webrender, and enable it by default on linux64-qr test platforms. r=dustin
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc0db07e9495
Run the linux64-qr test platforms using the regular linux64 build platform, and remove the linux64-qr build platform. r=dustin
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17411eb12bd5
Remove superfluous closing bracket which breaks Firefox media tests. r=bustage-fix
You need to log in before you can comment on or make changes to this bug.