Closed
Bug 1342508
Opened 7 years ago
Closed 7 years ago
[geckoview] Add page reload
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: esawin, Assigned: esawin)
References
Details
Attachments
(2 files, 1 obsolete file)
1.49 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
20.82 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
Add GeckoView.reload() as part of the navigation API.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8841020 -
Flags: review?(snorp)
Assignee | ||
Comment 2•7 years ago
|
||
Let's make it consistent before it's too late.
Attachment #8841021 -
Flags: review?(nchen)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8841021 -
Attachment is obsolete: true
Attachment #8841021 -
Flags: review?(nchen)
Attachment #8841078 -
Flags: review?(nchen)
Attachment #8841020 -
Flags: review?(snorp) → review+
Comment on attachment 8841020 [details] [diff] [review] 0001-Bug-1342508-Add-GeckoView.reload.-r-snorp.patch Review of attachment 8841020 [details] [diff] [review]: ----------------------------------------------------------------- There are different flags for reload. You can for instance reload and bypass cache/service workers, etc.
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #4) > There are different flags for reload. You can for instance reload and bypass > cache/service workers, etc. We can address it in bug 1322577 to have consistent handling of load and reload flags.
Comment 6•7 years ago
|
||
Comment on attachment 8841078 [details] [diff] [review] 0002-Bug-1342508-Make-code-style-consistent-across-GeckoV.patch Review of attachment 8841078 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java @@ +64,5 @@ > > static native void open(Window instance, GeckoView view, > Object compositor, EventDispatcher dispatcher, > + String mChromeUri, GeckoBundle settings, > + int mScreenId); These shouldn't be changed
Attachment #8841078 -
Flags: review?(nchen) → review+
Pushed by esawin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/de31af4868b3 [1.0] Add GeckoView.reload. r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/35286e286aba [2.1] Make code style consistent across GeckoView. r=jchen
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/de31af4868b3 https://hg.mozilla.org/mozilla-central/rev/35286e286aba
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•