1342508 - [geckoview] Add page reload

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Eugen Sawin [:esawin]]

Add GeckoView.reload() as part of the navigation API.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1342508-Add-GeckoView.reload.-r-snorp.patch

Comment 2

[Eugen Sawin [:esawin]]

Attachment: 0002-Bug-1342508-Make-code-style-consistent-across-GeckoV.patch

Let's make it consistent before it's too late.

Comment 3

[Eugen Sawin [:esawin]]

Attachment: 0002-Bug-1342508-Make-code-style-consistent-across-GeckoV.patch

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8841020 [details] [diff] [review]
0001-Bug-1342508-Add-GeckoView.reload.-r-snorp.patch

Review of attachment 8841020 [details] [diff] [review]:
-----------------------------------------------------------------

There are different flags for reload. You can for instance reload and bypass cache/service workers, etc.

Comment 5

[Eugen Sawin [:esawin]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #4)
> There are different flags for reload. You can for instance reload and bypass
> cache/service workers, etc.

We can address it in bug 1322577 to have consistent handling of load and reload flags.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8841078 [details] [diff] [review]
0002-Bug-1342508-Make-code-style-consistent-across-GeckoV.patch

Review of attachment 8841078 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java
@@ +64,5 @@
>  
>          static native void open(Window instance, GeckoView view,
>                                  Object compositor, EventDispatcher dispatcher,
> +                                String mChromeUri, GeckoBundle settings,
> +                                int mScreenId);

These shouldn't be changed

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de31af4868b3
[1.0] Add GeckoView.reload. r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/35286e286aba
[2.1] Make code style consistent across GeckoView. r=jchen

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de31af4868b3
https://hg.mozilla.org/mozilla-central/rev/35286e286aba