[geckoview] Add page reload

RESOLVED FIXED in Firefox 54

Status

defect
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: esawin, Assigned: esawin)

Tracking

unspecified
mozilla54
All
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

2 years ago
Add GeckoView.reload() as part of the navigation API.
Assignee

Comment 2

2 years ago
Let's make it consistent before it's too late.
Attachment #8841021 - Flags: review?(nchen)
Assignee

Comment 3

2 years ago
Attachment #8841021 - Attachment is obsolete: true
Attachment #8841021 - Flags: review?(nchen)
Attachment #8841078 - Flags: review?(nchen)
Attachment #8841020 - Flags: review?(snorp) → review+
Comment on attachment 8841020 [details] [diff] [review]
0001-Bug-1342508-Add-GeckoView.reload.-r-snorp.patch

Review of attachment 8841020 [details] [diff] [review]:
-----------------------------------------------------------------

There are different flags for reload. You can for instance reload and bypass cache/service workers, etc.
Assignee

Comment 5

2 years ago
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #4)
> There are different flags for reload. You can for instance reload and bypass
> cache/service workers, etc.

We can address it in bug 1322577 to have consistent handling of load and reload flags.
Comment on attachment 8841078 [details] [diff] [review]
0002-Bug-1342508-Make-code-style-consistent-across-GeckoV.patch

Review of attachment 8841078 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java
@@ +64,5 @@
>  
>          static native void open(Window instance, GeckoView view,
>                                  Object compositor, EventDispatcher dispatcher,
> +                                String mChromeUri, GeckoBundle settings,
> +                                int mScreenId);

These shouldn't be changed
Attachment #8841078 - Flags: review?(nchen) → review+

Comment 7

2 years ago
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de31af4868b3
[1.0] Add GeckoView.reload. r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/35286e286aba
[2.1] Make code style consistent across GeckoView. r=jchen

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/de31af4868b3
https://hg.mozilla.org/mozilla-central/rev/35286e286aba
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Updated

3 months ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.