1342514 - Unable to build FirefoxBeta/Firefox targets with Swift Optimizations on

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect, P3)

Description

[Stephan Leroux [:sleroux]]

After the Swift 3 migration, we're no longer able to compile our distribution targets (Beta/Release) using either Whole Module Optimization or Single-File Optimizations. Setting it single-file shows that the Swift compiler crashes when trying to process Sync's ThreeWayMerger.swift.

Marking as blocking/P1 since we can't really submit the app with optimizitions off.

Comment 1

[Stephan Leroux [:sleroux]]

Building on Xcode 8.3b3 works. Looks like the segfault issue was fixed between 8.2 and 8.3. It might be worth holding off until 8.3 gets released in which case we can just use that for production releases. Closing for now.

Comment 2

[Stephan Leroux [:sleroux]]

Considering that Xcode 8.4 is not out yet and we're shipping next week we should find a way to make this work. I'll take a look today.

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2512

Comment 4

[Richard Newman [:rnewman]]

Don't forget to file a bug to re-enable that code :)

Comment 5

[Stephan Leroux [:sleroux]]

Opened follow up bug to uncomment out this code when 8.3 code comes out

https://bugzilla.mozilla.org/show_bug.cgi?id=1346370

Comment 6

[Stephan Leroux [:sleroux]]

This patch only lives on the v7.x branch so we won't need to back this out. Closing this bug since it works on Xcode 8.3.