Closed Bug 1342575 Opened 3 years ago Closed 3 years ago

Remove superfluous variables from SeaMonkey confvars.sh

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set

Tracking

(seamonkey2.51 fixed)

RESOLVED FIXED
seamonkey2.51
Tracking Status
seamonkey2.51 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1341790 +++

confvars.sh has a lot of no more supported variables. We should remove them.
Attachment #8841112 - Flags: review?(iann_bugzilla)
Comment on attachment 8841112 [details] [diff] [review]
1342575-confvars.patch

I rather leave MOZ_BINARY_EXTENSIONS until it is removed from m-c
r=me with that change.
Attachment #8841112 - Flags: review?(iann_bugzilla) → review+
(In reply to Ian Neal from comment #2)
> Comment on attachment 8841112 [details] [diff] [review]
> 1342575-confvars.patch
> 
> I rather leave MOZ_BINARY_EXTENSIONS until it is removed from m-c
> r=me with that change.

Okay, so it has been removed (bug 1314955 as mentioned on irc by frg), just not very well - https://dxr.mozilla.org/comm-central/search?q=MOZ_BINARY_EXTENSIONS

r=me with patch as is.
Status: NEW → ASSIGNED
But then they haven't removed it very well. This variable is still on a lot of places https://dxr.mozilla.org/comm-central/search?q=MOZ_BINARY_EXTENSIONS+-path%3Aobj-x86
Jupp. I don't know why this is still in the code. With comment 0 and the patch in mozilla a binary will just print a message in the console that its not supported. Makes no sense to keep it unless I overlooked something. FF is not using it and for Lightning there was Bug 1318258.

https://bugzilla.mozilla.org/show_bug.cgi?id=1314955#c0
Lets see how it works.
https://hg.mozilla.org/comm-central/rev/4b1fc11b94209e7cf767f4805a0b774b209f7a98
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.51
You need to log in before you can comment on or make changes to this bug.