1342588 - Browser Toolbox profile incorrectly stored in ~/Library/Caches on macOS

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

At some point (around 2016-05-24 looking my timestamps), the chrome_debugger_profile on macOS moved from:

~/Library/Application Support/Firefox/Profiles/<PROFILE>/chrome_debugger_profile

to:

~/Library/Caches/Firefox/Profiles/<PROFILE>/chrome_debugger_profile

but this is incorrect, since it's not temporary cache data.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=342b301840c0b27400d8bdec82f228d9a04ac9c0

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1342588 - Use ProfD for Browser Toolbox profile.

Originally, the profile was placed in `ProfLD` instead of `ProfD`.  On some
systems, such as macOS, `ProfLD` is in the user's Caches directory, which is not
an appropriate place to store supposedly persistent profile data.

Review commit: https://reviewboard.mozilla.org/r/116376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116376/

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8842585 [details]
Bug 1342588 - Use ProfD for Browser Toolbox profile.

https://reviewboard.mozilla.org/r/116376/#review118342

Looks good, thanks for catching that. I didn't realized this profile was meant to be persistent!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1878102f1cea
Use ProfD for Browser Toolbox profile. r=ochameau

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1878102f1cea