Closed Bug 1342634 Opened 8 years ago Closed 8 years ago

Use --optimize/--no-optimize style in autospider.py

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Use --optimize/--no-optimize style in autospider.py
2.10 KB, patch
sfink
: review+
Details | Diff | Splinter Review
followup for bug 1342301 currently it shows "--optimize OPT" in --help, but I have no idea how to store False. (I should've reviewed more thoroughly :P so, it would be better using --optimize/--no-optimize style
Changed --optimize to store_true action, and also added --no-optimize, both in mutually exclusive group.
Attachment #8841154 - Flags: review?(sphink)
Comment on attachment 8841154 [details] [diff] [review] Use --optimize/--no-optimize style in autospider.py Review of attachment 8841154 [details] [diff] [review]: ----------------------------------------------------------------- Oh, sorry! I somehow just assumed that type=bool would do that automatically, and only tested the positive case. (I was probably thinking of Perl's Getopt::Long, which *does* add a --no-X for any boolean argument.)
Attachment #8841154 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/a3d1476da61f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: