Closed
Bug 1342634
Opened 7 years ago
Closed 7 years ago
Use --optimize/--no-optimize style in autospider.py
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
2.10 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
followup for bug 1342301 currently it shows "--optimize OPT" in --help, but I have no idea how to store False. (I should've reviewed more thoroughly :P so, it would be better using --optimize/--no-optimize style
Assignee | ||
Comment 1•7 years ago
|
||
Changed --optimize to store_true action, and also added --no-optimize, both in mutually exclusive group.
Attachment #8841154 -
Flags: review?(sphink)
Comment 2•7 years ago
|
||
Comment on attachment 8841154 [details] [diff] [review] Use --optimize/--no-optimize style in autospider.py Review of attachment 8841154 [details] [diff] [review]: ----------------------------------------------------------------- Oh, sorry! I somehow just assumed that type=bool would do that automatically, and only tested the positive case. (I was probably thinking of Perl's Getopt::Long, which *does* add a --no-X for any boolean argument.)
Attachment #8841154 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3d1476da61fcb6278703f9ade471e20fe01978a Bug 1342634 - Use --optimize/--no-optimize style in autospider.py r=sfink
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a3d1476da61f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment 5•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/cc3d15e2afc6
status-firefox53:
--- → fixed
Comment 6•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr52/rev/d72e56823bbb
status-firefox-esr52:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•