Closed
Bug 1342648
Opened 7 years ago
Closed 7 years ago
Only assign PluralRules property when calling addIntlExtras in test262 tests
Categories
(Core :: JavaScript: Internationalization API, defect)
Core
JavaScript: Internationalization API
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
2.00 KB,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
Avoids breaking test262 when other intl-extras overwrite default Intl properties, cf. bug 1329904, comment #32.
|
Assignee | |
Comment 1•7 years ago
|
||
With this patch the Intl extras are first copied into a temporary object, and then we only add PluralRules to the standard Intl object instead of every Intl extra. (js/src/tests/test262/intl402/PluralRules/shell.js is generated file from the test262 update script, it contains the content from js/src/tests/test262-intl-extras.js)
Attachment #8841170 -
Flags: review?(gandalf)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8841170 [details] [diff] [review] bug1342648.patch thanks!
Attachment #8841170 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1385bc84ccb5564640b4359fc7816a4b924e516e
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5a989a69ea61 Only define PluralRules constructor when calling addIntlExtras in test262 PluralRules tests. r=gandalf
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5a989a69ea61
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•