Closed Bug 1342665 Opened 6 years ago Closed 6 years ago

Disable header sorting for js/

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 1342665 - Disable header sorting for js/
59 bytes, text/x-review-board-request
jolesen
: review+
Details 
By default, clang-format is going to sort the headers.
This is breaking the test:
 make -C obj-x86_64-pc-linux-gnu/js/src/ check-style
[..]
--- check_spider_monkey_style.py expected output
+++ check_spider_monkey_style.py actual output
@@ -1,5 +1,209 @@
+js/src/tests/style/HeaderCycleB4-inl.h:1:2: error:
+    "tests/style/HeaderCycleB1-inl.h" should be included after "tests/style/jsheadercycleB5inlines.h"
+
Assignee: nobody → sledru
Blocks: 1274087
Comment on attachment 8842375 [details]
Bug 1342665 - Disable header sorting for js/

https://reviewboard.mozilla.org/r/116252/#review117942

Looks good.
Attachment #8842375 - Flags: review?(jolesen) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9790d28380c2
Disable header sorting for js/ r=jolesen
https://hg.mozilla.org/mozilla-central/rev/9790d28380c2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.