Disable header sorting for js/

RESOLVED FIXED in Firefox 54

Status

()

Core
Rewriting and Analysis
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
By default, clang-format is going to sort the headers.
This is breaking the test:
 make -C obj-x86_64-pc-linux-gnu/js/src/ check-style
[..]
--- check_spider_monkey_style.py expected output
+++ check_spider_monkey_style.py actual output
@@ -1,5 +1,209 @@
+js/src/tests/style/HeaderCycleB4-inl.h:1:2: error:
+    "tests/style/HeaderCycleB1-inl.h" should be included after "tests/style/jsheadercycleB5inlines.h"
+
(Assignee)

Updated

9 months ago
Assignee: nobody → sledru
(Assignee)

Updated

9 months ago
Blocks: 1274087
(Assignee)

Comment 1

9 months ago
noise
https://treeherder.mozilla.org/#/jobs?repo=try&revision=34e5c9d5af0e
Comment hidden (mozreview-request)

Comment 3

9 months ago
mozreview-review
Comment on attachment 8842375 [details]
Bug 1342665 - Disable header sorting for js/

https://reviewboard.mozilla.org/r/116252/#review117942

Looks good.
Attachment #8842375 - Flags: review?(jolesen) → review+

Comment 4

9 months ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9790d28380c2
Disable header sorting for js/ r=jolesen

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9790d28380c2
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.