Closed
Bug 1342707
Opened 7 years ago
Closed 7 years ago
hidden symbol `_ZN6SkOpts9Init_neonEv' isn't defined
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | fixed |
firefox-esr52 | --- | fixed |
firefox53 | --- | fixed |
firefox54 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
lsalzman
:
review+
jcristau
:
approval-mozilla-aurora+
jcristau
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-release+
|
Details |
When building on Debian armel, the build fails with: gfx/skia/skia/src/core/SkOpts.cpp:213: undefined reference to `SkOpts::Init_neon()' /usr/bin/ld: libxul.so: hidden symbol `_ZN6SkOpts9Init_neonEv' isn't defined The reason is that neon code is entirely disabled in that case, but the initialization code in SkOpts.cpp is not ifdef'ed out at the same time.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
status-firefox51:
--- → unaffected
status-firefox52:
--- → affected
status-firefox53:
--- → affected
Updated•7 years ago
|
Attachment #8841268 -
Flags: review?(jmuizelaar) → review?(lsalzman)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8841268 [details] Bug 1342707 - Don't use Init_neon if runtime detection of neon is not enabled. https://reviewboard.mozilla.org/r/115536/#review117044
Attachment #8841268 -
Flags: review?(lsalzman) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/f2388b4ac74c Don't use Init_neon if runtime detection of neon is not enabled. r=lsalzman
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8841268 [details] Bug 1342707 - Don't use Init_neon if runtime detection of neon is not enabled. Approval Request Comment [Feature/Bug causing the regression]: Regression from an update to Skia in the 52 cycle [User impact if declined]: Failure to build on Debian armel [Is this code covered by automated tests?]: NPOTB [Has the fix been verified in Nightly?]: NPOTB [Needs manual test from QE? If yes, steps to reproduce]: N/A [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]: No [Why is the change risky/not risky?]: It is a noop for Android arm builds. [String changes made/needed]: N/A
Attachment #8841268 -
Flags: approval-mozilla-esr52?
Attachment #8841268 -
Flags: approval-mozilla-beta?
Attachment #8841268 -
Flags: approval-mozilla-aurora?
Comment 5•7 years ago
|
||
Comment on attachment 8841268 [details] Bug 1342707 - Don't use Init_neon if runtime detection of neon is not enabled. ok let's try and get this build fix in 52 rc2
Attachment #8841268 -
Flags: approval-mozilla-release+
Attachment #8841268 -
Flags: approval-mozilla-esr52?
Attachment #8841268 -
Flags: approval-mozilla-beta?
Attachment #8841268 -
Flags: approval-mozilla-beta+
Attachment #8841268 -
Flags: approval-mozilla-aurora?
Attachment #8841268 -
Flags: approval-mozilla-aurora+
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f2388b4ac74c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Assignee | ||
Comment 7•7 years ago
|
||
Is 52 release going to be merged into esr52? (I hope the answer is yes, but who knows. ISTR having seen things landed there)
Comment 8•7 years ago
|
||
Yes
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/a5a59d3ea53d
Comment 10•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/0e98754ce520
Comment 11•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/0e98754ce520
Comment 12•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr52/rev/0e98754ce520
status-firefox-esr52:
--- → fixed
Comment 13•7 years ago
|
||
Setting qe-verify- based on Mike's assessment on manual testing needs (see Comment 4).
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•