Closed Bug 1342720 Opened 4 years ago Closed 4 years ago

Optimize away the cost of creating and destroying nsBidi from CanvasRenderingContext2D::DrawOrMeasureText()

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The ICU implementation of ~nsBidi is particularly expensive because
it calls free() several times.
Assignee: nobody → ehsan
Blocks: 1342713
Attachment #8841286 - Flags: review?(amarchesini) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1d03f028cb1
Optimize away the cost of creating and destroying nsBidi from CanvasRenderingContext2D::DrawOrMeasureText(); r=baku
Nice!  I'd been seeing this in profiles, but thought it was there for a reason...
https://hg.mozilla.org/mozilla-central/rev/a1d03f028cb1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.