Remove legacy generator from calendar/providers/gdata/.

RESOLVED FIXED in 5.9

Status

Calendar
Provider: GData
P3
normal
RESOLVED FIXED
a year ago
7 months ago

People

(Reporter: arai, Assigned: arai)

Tracking

unspecified
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
Now gdata can use ES6 generator.
(Assignee)

Comment 1

a year ago
Created attachment 8841300 [details] [diff] [review]
Remove legacy generator from calendar/providers/gdata/.

changed legacy generator to ES6 generator,
and also replaced `throw new Task.Result(x)` to `return x`.
Attachment #8841300 - Flags: review?(philipp)
Comment on attachment 8841300 [details] [diff] [review]
Remove legacy generator from calendar/providers/gdata/.

Review of attachment 8841300 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, looks good!

::: calendar/providers/gdata/modules/gdataSession.jsm
@@ +373,5 @@
>          }
>      },
>  
>      asyncPaginatedRequest: function(aRequest, onFirst, onEach, onLast) {
> +        return Task.spawn(function*() {

Maybe you can turn some of these into using Task.async() instead?
Attachment #8841300 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

a year ago
Thank you for reviewing :)

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Comment on attachment 8841300 [details] [diff] [review]
> Remove legacy generator from calendar/providers/gdata/.
> 
> Review of attachment 8841300 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for the patch, looks good!
> 
> ::: calendar/providers/gdata/modules/gdataSession.jsm
> @@ +373,5 @@
> >          }
> >      },
> >  
> >      asyncPaginatedRequest: function(aRequest, onFirst, onEach, onLast) {
> > +        return Task.spawn(function*() {
> 
> Maybe you can turn some of these into using Task.async() instead?

yes, it would also work (while the diff becomes bigger, to reduce indentation)
(In reply to Tooru Fujisawa [:arai] from comment #3)
> Thank you for reviewing :)
> yes, it would also work (while the diff becomes bigger, to reduce
> indentation)

I don't mind this, if you want you could also attach a patch with the -w option. arai, are you still interested in making this change or should we push what you have (both is fine with me) ?
Flags: needinfo?(arai.unmht)
(Assignee)

Comment 5

10 months ago
sorry, I forgot to update depending bug field.
I was about to continue working on this (and bug 1340947) after bug 1342828 fixed, since I couldn't verify this patch without that


(In reply to Philipp Kewisch [:Fallen] from comment #4)
> (In reply to Tooru Fujisawa [:arai] from comment #3)
> > Thank you for reviewing :)
> > yes, it would also work (while the diff becomes bigger, to reduce
> > indentation)
> 
> I don't mind this, if you want you could also attach a patch with the -w
> option. arai, are you still interested in making this change or should we
> push what you have (both is fine with me) ?

I'm going to apply the change.
Depends on: 1342828
Flags: needinfo?(arai.unmht)
Thanks for the quick update!
Priority: -- → P3
All tests should run in a (try)build again, so do you plan to continue work on this issue?
Flags: needinfo?(arai.unmht)
(Assignee)

Comment 8

7 months ago
thanks.
I'm a bit busy now, I think I can continue from next week.
Philipp asked three months ago if you want to use Task.async() in some places (comment#2) which you agreed to (comment#5). Is the try run with the patch attached to this bug or with an updated patch? We can also simply check in the existing patch and open a new bug for the remaining work.
Flags: needinfo?(arai.unmht)
(Assignee)

Comment 11

7 months ago
Created attachment 8895034 [details] [diff] [review]
Remove legacy generator from calendar/providers/gdata/. r=Fallen

here's the updated patch that uses Task.async, and this is for the try run.
Attachment #8841300 - Attachment is obsolete: true
Flags: needinfo?(arai.unmht)
Attachment #8895034 - Flags: review+
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 12

7 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7953ac6987eb
Remove legacy generator from calendar/providers/gdata/. r=philipp
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

7 months ago
Target Milestone: --- → 5.9
You need to log in before you can comment on or make changes to this bug.