1342737 - Avoid using nsCRT.h and nsCRTGlue.h in PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

There are a few places where we can use the safer functionality provided by the Mozilla string classes instead.

Comment 1

[:Cykesiopka]

Attachment: Bug 1342737 - Avoid using nsCRT.h and nsCRTGlue.h in PSM.

There are a few places where we can use the safer functionality provided by the
Mozilla string classes instead.

Also fixes Bug 1268657.

Review commit: https://reviewboard.mozilla.org/r/123574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123574/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8851203 [details]
Bug 1342737 - Avoid using nsCRT.h and nsCRTGlue.h in PSM.

https://reviewboard.mozilla.org/r/123574/#review126460

LGTM - just some nits.

::: commit-message-a5931:6
(Diff revision 1)
> +Bug 1342737 - Avoid using nsCRT.h and nsCRTGlue.h in PSM. r?keeler
> +
> +There are a few places where we can use the safer functionality provided by the
> +Mozilla string classes instead.
> +
> +Also fixes Bug 1268657.

nit: maybe briefly what that bug is so people don't have to go read it

::: security/manager/ssl/TransportSecurityInfo.cpp:213
(Diff revision 1)
>                              false, false, result);
>  }
>  
>  static nsresult
> -formatPlainErrorMessage(nsXPIDLCString const & host, int32_t port,
> +formatPlainErrorMessage(const nsCString& host, int32_t port,
>                          PRErrorCode err, 

nit: might be nice to remove some of these trailing spaces while we're in the area

::: security/manager/ssl/nsNSSIOLayer.cpp:26
(Diff revision 1)
>  #include "mozilla/Move.h"
>  #include "mozilla/Preferences.h"
>  #include "mozilla/Telemetry.h"
>  #include "nsArray.h"
>  #include "nsArrayUtils.h"
> +#include "nsCRT.h"

Er, wait, we need to add this here?

Comment 3

[:Cykesiopka]

Comment on attachment 8851203 [details]
Bug 1342737 - Avoid using nsCRT.h and nsCRTGlue.h in PSM.

https://reviewboard.mozilla.org/r/123574/#review126460

Thanks!

> nit: maybe briefly what that bug is so people don't have to go read it

Done.

> nit: might be nice to remove some of these trailing spaces while we're in the area

Done.

> Er, wait, we need to add this here?

This is here because the file still uses nsCRT for pref observation. Due to unified builds, it's probably not necessary to be here, but I added it just for correctness.
(One of these days I'll run IWYU on PSM and address all of these things at once...)

Comment 4

[:Cykesiopka]

Comment on attachment 8851203 [details]
Bug 1342737 - Avoid using nsCRT.h and nsCRTGlue.h in PSM.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123574/diff/1-2/

Comment 5

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=340c6e05b684cdbf967c3cf2110a931d7c1b9ea0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/420101b83dfc
Avoid using nsCRT.h and nsCRTGlue.h in PSM. r=keeler

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/420101b83dfc