Closed Bug 134275 Opened 23 years ago Closed 23 years ago

Find in page crosses table boundary when <td> tags not closed

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: selmer, Assigned: akkzilla)

Details

(Whiteboard: [adt3 rtm] Fixed on trunk,custrtm-)

Attachments

(1 file)

3/11 04 trunk build.

On a bugzilla bug query result page that has some bugs with priority P3 and
platform PC, search for P3P and be amazed that you'll get hits on the priority
combined with the platform columns in the table.

Bugzilla has malformed html (at least today as I write this).  I've reduced a
testcase that readily reproduces the problem:

<html>
<body>
   
<table>
  <tbody>
      <tr><td>P3<td>P</tr>
      <tr><td>P3<td>P</tr>
      <tr><td>P3<td>P</tr>
      <tr><td>P3<td>P</tr>
  </tbody>  
</table>

</body>
</html>

Note that other tags can come in between the text elements, but closing the
first <td> with a </td> seems to prevent the badness.  Adding *any* spaces seems
to avoid the bad match even if it's not visible.  (I used 
<tr><td>P3<td> <nobr>P</nobr></tr>)
This is mine.  I probably need to add td to the list of nodes to treat like
blocks.  Weird, I thought I had covered this case in the find regression tests.

Nominating for nsbeta1.  Should this also be moz 1.0?
Assignee: sgehani → akkana
Keywords: nsbeta1
qa --> pmac@netscape.com
QA Contact: paw → pmac
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0.1
Kathy or Charley, could I get a review for this?
Kin, could I get an sr?
OS: Windows NT → All
Hardware: PC → All
Comment on attachment 80437 [details] [diff] [review]
Simple patch to fix it

r=brade
Attachment #80437 - Flags: review+
Keywords: nsbeta1nsbeta1+
Whiteboard: [adt2 rtm]
Target Milestone: mozilla1.0.1 → mozilla1.0
Comment on attachment 80437 [details] [diff] [review]
Simple patch to fix it

sr=kin@netscape.com
Attachment #80437 - Flags: superreview+
Fixed on trunk, nominating for branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: adt1.0.0
Resolution: --- → FIXED
Whiteboard: [adt2 rtm] → [adt2 rtm] Fixed on trunk
verified on all platforms (trunk build: 2002-05-21-08-TRUNK)
Status: RESOLVED → VERIFIED
Adding custrtm-; no impact on customization.
Whiteboard: [adt2 rtm] Fixed on trunk → [adt2 rtm] Fixed on trunk,custrtm-
adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch, pending Driver's
approval.
Whiteboard: [adt2 rtm] Fixed on trunk,custrtm- → [adt3 rtm] Fixed on trunk,custrtm-
Comment on attachment 80437 [details] [diff] [review]
Simple patch to fix it

Please land this on the 1.0.1 branch.  Once there, remove the
"mozilla1.0.1+" keyword, and add the "fixed1.0.1"
Attachment #80437 - Flags: approval+
Checked in to the branch.
Keywords: mozilla1.0.1fixed1.0.1
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: