1342806 - Port bug 1342144 to mail [Remove version parameter from the type attribute of script elements]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

M-C did some version removing in html and xhtml files. We should follow.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: noJSVersion.patch

I used this sed script in /mail: find . ! -wholename '*/.hg*' -type f \( -iname '*.html' -o -iname '*.xhtml' -o -iname '*.xul' -o -iname '*.js' \) -exec sed -i -e 's/\(\(text\|application\)\/javascript\);version=1.[0-9]/\1/g' {} \;

I haven't touched following files because they use CR/LF line endings and this would be changed to LF: mail/base/test/unit/head_mailbase_maildir.js, mail/components/cloudfile/content/emptySettings.xhtml, mail/test/resources/mozmill/mozmill/extension/content/jquery/jquery-ui-1.7.1.custom.min.js and mail/test/resources/mozmill/mozmill/extension/content/overlay.js.

Comment 2

[:aceman]

Thanks.

Can you also make a separate patch for the 3 cases in IM?

im/themes/messages/bubbles/Footer.html
<script type="application/javascript;version=1.8">
im/themes/messages/dark/Footer.html
<script type="application/javascript;version=1.8">
im/themes/messages/papersheets/Footer.html
<script type="application/javascript;version=1.8">

(In reply to Richard Marti (:Paenglab) from comment #1)
> I used this sed script in /mail: find . ! -wholename '*/.hg*' -type f \(
> -iname '*.html' -o -iname '*.xhtml' -o -iname '*.xul' -o -iname '*.js' \)
> -exec sed -i -e
> 's/\(\(text\|application\)\/javascript\);version=1.[0-9]/\1/g' {} \;
> 
> I haven't touched following files because they use CR/LF line endings and
> this would be changed to LF: mail/base/test/unit/head_mailbase_maildir.js,
> mail/components/cloudfile/content/emptySettings.xhtml,

I haven't found anything to change in these files.

> mail/test/resources/mozmill/mozmill/extension/content/jquery/jquery-ui-1.7.1.
> custom.min.js and
> mail/test/resources/mozmill/mozmill/extension/content/overlay.js.

This is fine, these are external files we should not change.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: noJSVersionIM.patch

IM part.

Comment 4

[Richard Marti (:Paenglab)]

(In reply to :aceman from comment #2)
> 
> (In reply to Richard Marti (:Paenglab) from comment #1)
> > I used this sed script in /mail: find . ! -wholename '*/.hg*' -type f \(
> > -iname '*.html' -o -iname '*.xhtml' -o -iname '*.xul' -o -iname '*.js' \)
> > -exec sed -i -e
> > 's/\(\(text\|application\)\/javascript\);version=1.[0-9]/\1/g' {} \;
> > 
> > I haven't touched following files because they use CR/LF line endings and
> > this would be changed to LF: mail/base/test/unit/head_mailbase_maildir.js,
> > mail/components/cloudfile/content/emptySettings.xhtml,
> 
> I haven't found anything to change in these files.

The script found them.

Comment 5

[:aceman]

Comment on attachment 8841372 [details] [diff] [review]
noJSVersion.patch

Review of attachment 8841372 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/cloudfile/content/Box/management.xhtml
@@ +14,1 @@
>              src="chrome://messenger/content/protovis-r2.6-modded.js"/>

This seems to be a 3rd party library again so we will see if it works in the higher JS version. Sadly the cloudfile code is hard to test, if you don't have account at Box or Hightail.

Comment 6

[Patrick Cloke [:clokep]]

Comment on attachment 8841439 [details] [diff] [review]
noJSVersionIM.patch

Review of attachment 8841439 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Richard Marti (:Paenglab)]

(In reply to :aceman from comment #5)
> Comment on attachment 8841372 [details] [diff] [review]
> noJSVersion.patch
> 
> Review of attachment 8841372 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/components/cloudfile/content/Box/management.xhtml
> @@ +14,1 @@
> >              src="chrome://messenger/content/protovis-r2.6-modded.js"/>
> 
> This seems to be a 3rd party library again so we will see if it works in the
> higher JS version. Sadly the cloudfile code is hard to test, if you don't
> have account at Box or Hightail.

Should I revert this or is it okay to check-in like it is? I can't test too.

Comment 8

[:aceman]

I'd say leave the version specified for total safety. The library will only get older and older and may stop working with the new JS features from m-c.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: noJSVersion.patch

Reverted th removal of the version attribute for protovis-r2.6-modded.js.

Comment 10

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/a4c510e01d6fd831ac80bcb936165ff1986e08a3
https://hg.mozilla.org/comm-central/rev/19fdf87ad6387611db4af35bb7fcf4b788044d09

Comment 11

[:aceman]

It seems there are still about 2 occurrences left (https://dxr.mozilla.org/comm-central/search?q=%3Cscript+type%3D%22application%2Fjavascript%3Bversion%3D&redirect=false), including suite. Would you do a followup?