1342808 - Can't play video file generated by DJI Mavic Pro

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

Some videos play; some show the message that the video can't be played because it's corrupt.

They are mov file, so MP4.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1342808: Ignore user data track.

That's the 'udta' box. They serve no purpose as far as we're concerned and stagefright handling of it is buggy.

Review commit: https://reviewboard.mozilla.org/r/116568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116568/

Comment 2

[Gerald Squelart [:gerald] (he/him)]

Comment on attachment 8842785 [details]
Bug 1342808: Ignore user data track.

https://reviewboard.mozilla.org/r/116568/#review118174

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/354fae785150
Ignore user data track. r=gerald

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/354fae785150

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8842785 [details]
Bug 1342808: Ignore user data track.

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: videos from a popular gadget can't be played
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: by myself
[Needs manual test from QE? If yes, steps to reproduce]: get a mavic pro, record a video, attempt to play it in FF
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: we ignore a mp4 box, that isn't documented.
[String changes made/needed]: none

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8842785 [details]
Bug 1342808: Ignore user data track.

53 will be beta in a few hours.  Did you mean to nominate this for 52?  (It's too late for 52.0 at this point, and I'm not sure if this is worth including in a dot release)

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8842785 [details]
Bug 1342808: Ignore user data track.

Sound OK for uplift to beta.
Drone video aficionados of the world, please test next week with beta 2.

Comment 8

[[Back July 11] Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-beta/rev/d4be754fcafc