1342813 - $SIG{__DIE__} is set to Bugzilla::_console_die() when running under Plack

Status: NEW

(Bugzilla :: Bugzilla-General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

Attachment: what-is-die.cgi

I suspect we need to set $BZ_PLACK much earlier in app.psgi, else we think we're in command line mode and set a DIE handler to _console_die which breaks plack's error reporting.

I attached the .cgi I wrote to debug this.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: Screen Shot 2017-02-26 at 18.01.34.png

Fixed it! Now we get beautiful Plack stack traces when running in development mode.

For details, see:
https://metacpan.org/pod/Plack::Middleware::StackTrace

Comment 2

[GitHub Autolander Bot]

Attachment: [bugzilla] dylanwh:bug-1342813 > bugzilla:master

Comment 3

[Dylan Hardison [:dylanAtHome]]

Comment on attachment 8841379 [details] [review]
[bugzilla] dylanwh:bug-1342813 > bugzilla:master

Last one. This is the last one in my series of quick fixups that touches app.psgi. You could actually review this and transfer the r+ to the other branches now that I think about it. The choice is yours.

Comment 4

[Jeff Fearn 🐞]

Comment on attachment 8841379 [details] [review]
[bugzilla] dylanwh:bug-1342813 > bugzilla:master

Unless for init_page call needs a condition or needs to be removed.