$SIG{__DIE__} is set to Bugzilla::_console_die() when running under Plack

NEW
Assigned to

Status

()

Bugzilla
Bugzilla-General
8 months ago
5 months ago

People

(Reporter: dylan, Assigned: dylanAtHome)

Tracking

5.1.1
Bugzilla 6.0

Details

Attachments

(3 attachments)

(Reporter)

Description

8 months ago
Created attachment 8841375 [details]
what-is-die.cgi

I suspect we need to set $BZ_PLACK much earlier in app.psgi, else we think we're in command line mode and set a DIE handler to _console_die which breaks plack's error reporting.

I attached the .cgi I wrote to debug this.
(Reporter)

Updated

8 months ago
Assignee: general → dylan
Target Milestone: --- → Bugzilla 6.0
(Reporter)

Comment 1

8 months ago
Created attachment 8841378 [details]
Screen Shot 2017-02-26 at 18.01.34.png

Fixed it! Now we get beautiful Plack stack traces when running in development mode.

For details, see:
https://metacpan.org/pod/Plack::Middleware::StackTrace

Comment 2

8 months ago
Created attachment 8841379 [details] [review]
[bugzilla] dylanwh:bug-1342813 > bugzilla:master
(Reporter)

Updated

8 months ago
Assignee: dylan → dylan
(Assignee)

Comment 3

8 months ago
Comment on attachment 8841379 [details] [review]
[bugzilla] dylanwh:bug-1342813 > bugzilla:master

Last one. This is the last one in my series of quick fixups that touches app.psgi. You could actually review this and transfer the r+ to the other branches now that I think about it. The choice is yours.
Attachment #8841379 - Flags: review?(jfearn)

Comment 4

5 months ago
Comment on attachment 8841379 [details] [review]
[bugzilla] dylanwh:bug-1342813 > bugzilla:master

Unless for init_page call needs a condition or needs to be removed.
Attachment #8841379 - Flags: review?(jfearn) → review-
You need to log in before you can comment on or make changes to this bug.