1342818 - Move shadowdb, proxy, and memcached options out of data/params.json into localconfig

Status: NEW

(Bugzilla :: Bugzilla-General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

When configuration data is "operational" (as opposed to "administrative") it should go into localconfig.

Examples of this:

* memcached
* inbound_proxies (being able to set this as an admin is dangerous anyway!)
* shadowdb
* urlbase/sslbase/ssl_redirect (this is a nightmare from a configuration, documentation, and usability standpoint)

Comment 1

[GitHub Autolander Bot]

Attachment: [bugzilla] dylanwh:bug-1342818 > bugzilla:master

Comment 2

[Dylan Hardison [:dylanAtHome]]

Comment on attachment 8841402 [details] [review]
[bugzilla] dylanwh:bug-1342818 > bugzilla:master

This patch comes from operational experience with BMO. Basically the inbound proxies, database parameters, memcached parameters, and proxy url are all the things that may be managed by a configuration management system.

You don't want to have operations touching data/params.json.

This patch migrates the values (if they exist) from data/params to localconfig.
It doesn't touch the way these new configuration values are handled, but we can re-purpose bug 1306636 for that. In practice people are not overly concerned with those messages anyway.

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 8841402 [details] [review]
[bugzilla] dylanwh:bug-1342818 > bugzilla:master

r=gerv on the code; sorry it took so long. However, before or at the same time as landing, you need to also update the documentation.

Gerv