1342833 - WebRenderBridgeParent::ClearResources() does not clear DisplayList

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

WebRenderBridgeParent::ClearResources() is called during WebRenderBridgeParent destruction. It delete several resources related to webrender. But it does not clear DisplayList that is related to pipeline id.

Comment 1

[Sotaro Ikeda [:sotaro]]

There is a issue related to it. But it seems better to clean it as much as possible by using current API soon.
 https://github.com/servo/webrender/issues/691
 https://github.com/servo/webrender/issues/930

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Clear DisplayList in WebRenderBridgeParent::ClearResources()

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8c3c971881b54039469834106cb90978010d160

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Bug 1341064 removes mBuilder.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Clear DisplayList in WebRenderBridgeParent::ClearResources()

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Clear DisplayList in WebRenderBridgeParent::ClearResources()

Comment 7

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1fbb11c444279880881c39a0ec7e17dbafa37946

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8842852 [details] [diff] [review]
patch - Clear DisplayList in WebRenderBridgeParent::ClearResources()

Review of attachment 8842852 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/webrender_bindings/src/bindings.rs
@@ +273,5 @@
> +
> +    api.set_root_display_list(Some(root_background_color),
> +                              epoch,
> +                              LayoutSize::new(0.0, 0.0),
> +                              (pipeline_id, dl, aux),

You can just call frame_builder.dl_builder.finalize() directly here instead of assigning it to the variables above.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Clear DisplayList in WebRenderBridgeParent::ClearResources()

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/83bb36588e3a
WebRenderBridgeParent::ClearResources() does not clear DisplayList r=jrmuizel

Comment 11

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/83bb36588e3a