1342848 - Crash in mp4_demuxer::MP4Metadata::ReadTrackIndex

Status: RESOLVED DUPLICATE of bug 1342852

(Core :: Audio/Video: Playback, defect)

Description

[Matthew Gregan [:kinetik]]

This bug was filed from the Socorro interface and is 
report bp-9fbdb807-ec35-4272-b8cd-d79fd2170227.
=============================================================

Comment 1

[Matthew Gregan [:kinetik]]

In a debug build, I hit a panic at:

mp4parse_capi/src/lib.rs:677
677	                (empty_duration.0 - media_time.0) as i64 * scale.0 as i64

...which is likely handled by Alfredo's change in bug 1342852.

Assuming the release build is hitting the same bug, that suggests either underflow checking isn't enabled in release or we're silently turning panics into a non-error somewhere.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: bug1342848_nzh.mp4

Comment 3

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #1)
> Assuming the release build is hitting the same bug, that suggests either
> underflow checking isn't enabled in release or we're silently turning panics
> into a non-error somewhere.

It looks like it's the former.  Ralph pointed out that we haven't had debug-assertions enabled in release mode since August (bug 1231764 and 1335203, plus other confounding factors). :-(

FWIW, the attached testcase won't fail with mp4parse_capi/examples/{dump,test} because they don't call mp4parse_get_indice_table, which is where the underflow occurs.