clients engine should expose the server-modified timestamp for use in sorting clients by most-recently used.

RESOLVED FIXED in Firefox 54

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

2 years ago
In bug 1317223 we would like to sort client engine records by "most recently synced" so we can choose the engine most likely to respond to commands.

A reasonable approximation for this is the last-modified timestamp on the server record. This patch makes that time available in a serverLastModified field on the engine object. It is never written to the server and isn't exposed on *our* client record. It steals from the engine.lastSync attribute after uploading other records.

I first named it simply "lastModified", but the semantics of that WRT queueing a new command vs upload of that new command was fuzzy, so renamed it to make it clearer.
Assignee

Comment 1

2 years ago
mozreview got upset with me, so here it is
Assignee: nobody → markh
Attachment #8841448 - Flags: review?(rnewman)
Comment on attachment 8841448 [details] [diff] [review]
Bug_1342851___record_the_last_modified_time_of_a_Sync_client_record__r_rnewman.patch

Review of attachment 8841448 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8841448 - Flags: review?(rnewman) → review+
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8fb83d1d851
record the last-modified time of a Sync client record. r=rnewman
Keywords: checkin-needed
This was causing xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=80676915&repo=mozilla-inbound on some platforms, so I had to back it out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3bc19b609193
Flags: needinfo?(markh)
Assignee

Comment 5

2 years ago
(In reply to Wes Kocher (:KWierso) from comment #4)
> This was causing xpcshell failures like

Sorry about that - I had my patches in the wrong order - I'll reland via reviewboard, thanks!
Flags: needinfo?(markh)
Comment hidden (mozreview-request)
Assignee

Comment 7

2 years ago
Comment on attachment 8842398 [details]
Bug 1342851 - record the last-modified time of a Sync client record.

/me now battles reviewboard...
Attachment #8842398 - Flags: review?(rnewman) → review+
Assignee

Comment 8

2 years ago
mozreview-review
Comment on attachment 8842398 [details]
Bug 1342851 - record the last-modified time of a Sync client record.

https://reviewboard.mozilla.org/r/116264/#review117816

/me battles it from the other side...
Assignee

Updated

2 years ago
Attachment #8841448 - Attachment is obsolete: true
Comment hidden (mozreview-request)

Comment 10

2 years ago
mozreview-review
Comment on attachment 8842398 [details]
Bug 1342851 - record the last-modified time of a Sync client record.

https://reviewboard.mozilla.org/r/116264/#review118010
Attachment #8842398 - Flags: review?(rnewman) → review+

Comment 11

2 years ago
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/f0960b4bd9c4
record the last-modified time of a Sync client record. r=rnewman

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f0960b4bd9c4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.