[Affected versions]: Firefox 54.0a1 (2017-02-26) [Affected platforms]: Windows 10 64-bit Ubuntu 16.04 32-bit [Steps to reproduce]: 1.Launch Firefox with clean profile. 2.Create extensions.webextPermissionPrompts and set it to true. 3.Create xpinstall.signatures.dev-root and set it to true. 4.Change extensions.update.url to point to dev server. 5.Install the first version of the following webextension: https://addons-dev.allizom.org/en-US/firefox/addon/testupdate222/versions/ 6.Go to about:addons -> Extensions and check for updates.. [Expected Results]: The webextension is automatically updated to a new version with non-promptable permissions. There is no permission pop-up displayed. [Actual Results]: Permissions doorhanger is displayed even if there are no permissions listed.
Assignee: nobody → aswan
Priority: -- → P1
Comment on attachment 8843393 [details] Bug 1342896 Don't show prompts for interactive webextension updates with no new permissions https://reviewboard.mozilla.org/r/117154/#review118880 ::: browser/base/content/test/webextensions/browser_update_interactive_noprompt.js:12 (Diff revision 1) > - // Click the cancel button, wait to see the cancel event > - let cancelPromise = promiseInstallEvent(addon, "onInstallCancelled"); > - panel.secondaryButton.click(); > - yield cancelPromise; > > - addon = yield AddonManager.getAddonByID(ID); > + // XXX remove this when prompts are enabled by default is there a bug # about enabling prompts by default to put in here?
Attachment #8843393 - Flags: review?(rhelmer) → review+
Comment on attachment 8843393 [details] Bug 1342896 Don't show prompts for interactive webextension updates with no new permissions https://reviewboard.mozilla.org/r/117154/#review118880 > is there a bug # about enabling prompts by default to put in here? There is bug 1342142 but I've got basically this same comment in every file in this directory...
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/9a3a43ae9b2d Don't show prompts for interactive webextension updates with no new permissions r=rhelmer
Verified fixed on Firefox 54.0a1 (2017-03-06) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. Pending update is no longer displayed for non-promptable permissions while upgrading via interactive method.
You need to log in before you can comment on or make changes to this bug.