Closed Bug 1342911 Opened 4 years ago Closed 4 years ago

Remove macosx-universal mozconfigs and mozharness configs

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(1 file)

Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;
59 bytes, text/x-review-board-request
jlund
: review+
Details 
According to https://bugzilla.mozilla.org/show_bug.cgi?id=1339182#c9 it should be safe to remove the macosx-universal mozconfigs now. I imagine we can delete the related mozharness configs as well.
The only remaining file that references 'macosx-universal' in the tree is branch_specifics.py: https://dxr.mozilla.org/mozilla-central/rev/106a96755d3bcebe64bbbc3b521d65d262ba9c02/testing/mozharness/configs/builds/branch_specifics.py#204

Can we remove that too or does it need to stick around so long as esr52 is alive?
(In reply to Michael Shal [:mshal] from comment #2)
> The only remaining file that references 'macosx-universal' in the tree is
> branch_specifics.py:
> https://dxr.mozilla.org/mozilla-central/rev/
> 106a96755d3bcebe64bbbc3b521d65d262ba9c02/testing/mozharness/configs/builds/
> branch_specifics.py#204
> 
> Can we remove that too or does it need to stick around so long as esr52 is
> alive?

iiuc - that can be removed everywhere but mozilla-esr52. branch_specifics.py is read from in-tree so safe to remove from central
Comment on attachment 8848588 [details]
Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;

https://reviewboard.mozilla.org/r/121496/#review124678

I think this is fine to do. these files should be used by their respective trees/repos regardless if it's from bbot or taskcluster. So removing this on central is fine.
Attachment #8848588 - Flags: review?(jlund) → review+
Comment on attachment 8848588 [details]
Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;

Asking for re-review on removing the mozilla-esr52 block.
Attachment #8848588 - Flags: review+ → review?(jlund)
Comment on attachment 8848588 [details]
Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;

https://reviewboard.mozilla.org/r/121496/#review125166
Attachment #8848588 - Flags: review?(jlund) → review+
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17050f0040ef
Remove macosx-universal mozconfigs & mozharness configs; r=jlund
https://hg.mozilla.org/mozilla-central/rev/17050f0040ef
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.