1342911 - Remove macosx-universal mozconfigs and mozharness configs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Michael Shal [:mshal]]

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1339182#c9 it should be safe to remove the macosx-universal mozconfigs now. I imagine we can delete the related mozharness configs as well.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;

These mozconfigs are no longer used since we stopped doing universal
builds in bug 1295375.

Review commit: https://reviewboard.mozilla.org/r/121496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121496/

Comment 2

[Michael Shal [:mshal]]

The only remaining file that references 'macosx-universal' in the tree is branch_specifics.py: https://dxr.mozilla.org/mozilla-central/rev/106a96755d3bcebe64bbbc3b521d65d262ba9c02/testing/mozharness/configs/builds/branch_specifics.py#204

Can we remove that too or does it need to stick around so long as esr52 is alive?

Comment 3

[Jordan Lund (:jlund)]

(In reply to Michael Shal [:mshal] from comment #2)
> The only remaining file that references 'macosx-universal' in the tree is
> branch_specifics.py:
> https://dxr.mozilla.org/mozilla-central/rev/
> 106a96755d3bcebe64bbbc3b521d65d262ba9c02/testing/mozharness/configs/builds/
> branch_specifics.py#204
> 
> Can we remove that too or does it need to stick around so long as esr52 is
> alive?

iiuc - that can be removed everywhere but mozilla-esr52. branch_specifics.py is read from in-tree so safe to remove from central

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8848588 [details]
Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;

https://reviewboard.mozilla.org/r/121496/#review124678

I think this is fine to do. these files should be used by their respective trees/repos regardless if it's from bbot or taskcluster. So removing this on central is fine.

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8848588 [details]
Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121496/diff/1-2/

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8848588 [details]
Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;

Asking for re-review on removing the mozilla-esr52 block.

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8848588 [details]
Bug 1342911 - Remove macosx-universal mozconfigs & mozharness configs;

https://reviewboard.mozilla.org/r/121496/#review125166

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17050f0040ef
Remove macosx-universal mozconfigs & mozharness configs; r=jlund

Comment 9

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/17050f0040ef