MOZ_ASSERT(true) in toolkit/components/places/Database.cpp

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Places
P3
minor
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bobowen, Assigned: mak)

Tracking

10 Branch
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Just noticed this when searching for something else, I assume this [1] should be MOZ_ASSERT(false).

[1] https://hg.mozilla.org/mozilla-central/file/106a96755d3b/toolkit/components/places/Database.cpp#l251
Flags: needinfo?(mak77)
Comment hidden (obsolete)
Comment hidden (obsolete)
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8841950 [details]
Bug 1342946 - Fix wrong MOZ_ASSERT(true) in places/Database.cpp.

https://reviewboard.mozilla.org/r/115996/#review117402

Looks good, r=Standard8 assuming try passes.
Attachment #8841950 - Flags: review?(standard8) → review+

Comment 5

a year ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/69c6da620754
Fix wrong MOZ_ASSERT(true) in places/Database.cpp. r=standard8

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/69c6da620754
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Priority: -- → P3
Whiteboard: [fxsearch]
You need to log in before you can comment on or make changes to this bug.