Closed Bug 1342946 Opened 3 years ago Closed 3 years ago

MOZ_ASSERT(true) in toolkit/components/places/Database.cpp

Categories

(Toolkit :: Places, defect, P3, minor)

10 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: bobowen, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Just noticed this when searching for something else, I assume this [1] should be MOZ_ASSERT(false).

[1] https://hg.mozilla.org/mozilla-central/file/106a96755d3b/toolkit/components/places/Database.cpp#l251
Flags: needinfo?(mak77)
Comment on attachment 8841950 [details]
Bug 1342946 - Fix wrong MOZ_ASSERT(true) in places/Database.cpp.

https://reviewboard.mozilla.org/r/115996/#review117402

Looks good, r=Standard8 assuming try passes.
Attachment #8841950 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/69c6da620754
Fix wrong MOZ_ASSERT(true) in places/Database.cpp. r=standard8
https://hg.mozilla.org/mozilla-central/rev/69c6da620754
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Priority: -- → P3
Whiteboard: [fxsearch]
You need to log in before you can comment on or make changes to this bug.