Closed
Bug 1342956
Opened 7 years ago
Closed 7 years ago
Clean up promise_test handling in wasm spec testing
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(1 file)
10.12 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Also made a spec PR for fixing the bug upstream: https://github.com/WebAssembly/spec/pull/436 The WPT wasn't showing this issue because there's some unrelated parameters error in `new Uint8Array('hi');` happening before these tests.
Attachment #8841597 -
Flags: review?(luke)
Comment 1•7 years ago
|
||
Comment on attachment 8841597 [details] [diff] [review] fix-promise-test.patch Review of attachment 8841597 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8841597 -
Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c032cf7f54a0 Fix promise_test in wasm-testharness.js; r=luke
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c032cf7f54a0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•