Closed Bug 1342962 Opened 3 years ago Closed 3 years ago

Hide intermediate states during RDM toggle

Categories

(DevTools :: Responsive Design Mode, defect, P2)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rdm-v2])

Attachments

(1 file)

Toggling RDM is fairly fast now (at least on my machine), but it's still possible to still see the content jump up to the corner in a viewport sized frame, and then settle into the center when the UI has loaded.

We may be able to hide this intermittent state by disabling painting for the tab using APIs like `docShellIsActive` or others in nsITabParent.
Blocks: rdm-toggle
`docShellIsActive` doesn't work here, but we can use `visibility: hidden` here.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Summary: Disable painting tab during RDM toggle → Hide intermediate states during RDM toggle
Comment on attachment 8842661 [details]
Bug 1342962 - Hide intermediate states when toggling RDM.

https://reviewboard.mozilla.org/r/116416/#review118348

It looks like it is slightly faster also!
But to be honest, it still feels slow here...
Attachment #8842661 - Flags: review?(poirot.alex) → review+
Comment on attachment 8842661 [details]
Bug 1342962 - Hide intermediate states when toggling RDM.

https://reviewboard.mozilla.org/r/116416/#review118348

Yep, we can continue to improve perf overall... but this seems like nice improvement to take to hide the glitches.
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d85992359e22
Hide intermediate states when toggling RDM. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/d85992359e22
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.