Closed
Bug 1342962
Opened 7 years ago
Closed 7 years ago
Hide intermediate states during RDM toggle
Categories
(DevTools :: Responsive Design Mode, defect, P2)
DevTools
Responsive Design Mode
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rdm-v2])
Attachments
(1 file)
Toggling RDM is fairly fast now (at least on my machine), but it's still possible to still see the content jump up to the corner in a viewport sized frame, and then settle into the center when the UI has loaded. We may be able to hide this intermittent state by disabling painting for the tab using APIs like `docShellIsActive` or others in nsITabParent.
Assignee | ||
Updated•7 years ago
|
Blocks: rdm-toggle
Assignee | ||
Comment 1•7 years ago
|
||
`docShellIsActive` doesn't work here, but we can use `visibility: hidden` here.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Summary: Disable painting tab during RDM toggle → Hide intermediate states during RDM toggle
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42036076ca2f7335c65588153b07eae4e0cdd6c9
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8842661 [details] Bug 1342962 - Hide intermediate states when toggling RDM. https://reviewboard.mozilla.org/r/116416/#review118348 It looks like it is slightly faster also! But to be honest, it still feels slow here...
Attachment #8842661 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8842661 [details] Bug 1342962 - Hide intermediate states when toggling RDM. https://reviewboard.mozilla.org/r/116416/#review118348 Yep, we can continue to improve perf overall... but this seems like nice improvement to take to hide the glitches.
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d85992359e22 Hide intermediate states when toggling RDM. r=ochameau
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d85992359e22
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•