Hide intermediate states during RDM toggle

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Developer Tools: Responsive Design Mode
P2
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [rdm-v2])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Toggling RDM is fairly fast now (at least on my machine), but it's still possible to still see the content jump up to the corner in a viewport sized frame, and then settle into the center when the UI has loaded.

We may be able to hide this intermittent state by disabling painting for the tab using APIs like `docShellIsActive` or others in nsITabParent.
Blocks: 1278757
`docShellIsActive` doesn't work here, but we can use `visibility: hidden` here.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Summary: Disable painting tab during RDM toggle → Hide intermediate states during RDM toggle
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42036076ca2f7335c65588153b07eae4e0cdd6c9

Comment 4

10 months ago
mozreview-review
Comment on attachment 8842661 [details]
Bug 1342962 - Hide intermediate states when toggling RDM.

https://reviewboard.mozilla.org/r/116416/#review118348

It looks like it is slightly faster also!
But to be honest, it still feels slow here...
Attachment #8842661 - Flags: review?(poirot.alex) → review+
(Assignee)

Comment 5

10 months ago
mozreview-review-reply
Comment on attachment 8842661 [details]
Bug 1342962 - Hide intermediate states when toggling RDM.

https://reviewboard.mozilla.org/r/116416/#review118348

Yep, we can continue to improve perf overall... but this seems like nice improvement to take to hide the glitches.

Comment 6

10 months ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d85992359e22
Hide intermediate states when toggling RDM. r=ochameau

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d85992359e22
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.