Closed Bug 1342968 Opened 3 years ago Closed 3 years ago

Remove unused TabsLayout xml style attributes

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: twointofive, Assigned: twointofive)

References

Details

Attachments

(1 file)

Remove some xml style attributes on TabsLayouts that no longer apply now that all TabLayouts are RecyclerViews.

This also fixes bug 1337699 by removing old values-land/styles.xml TabsLayout definitions from when the tabs panel used to scroll horizontally in landscape mode.  (I'm planning on just closing bug 1337699 as fixed by this bug once this lands, but if preferred I'd be fine with landing just a single "android:scrollbars="vertical" change there - it just seems like the right way to fix that bug is to clean up all of the separate TabsLayout style definitions removed in this patch, but then that requires removing "android:orientation" as well, and then you're basically (but not quite!) at this bug.)
Comment on attachment 8841622 [details]
Bug 1342968 - Remove unused TabsLayout xml style attributes.

https://reviewboard.mozilla.org/r/115772/#review117770
Attachment #8841622 - Flags: review?(s.kaspari) → review+
Pushed by twointofive@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9c6a7e1b3f61
Remove unused TabsLayout xml style attributes. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/9c6a7e1b3f61
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.