Closed Bug 1342992 Opened 3 years ago Closed 3 years ago

mscom::WeakRef needs to be final

Categories

(Core :: IPC, defect)

Unspecified
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

Details

Attachments

(1 file)

Otherwise its non-virtual destructor doesn't pass static analysis.
Comment on attachment 8841658 [details]
Bug 1342992: Make mscom::Weakref final;

https://reviewboard.mozilla.org/r/115816/#review117438
Attachment #8841658 - Flags: review?(jmathies) → review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d34e52a93da4
Make mscom::Weakref final; r=jimm
https://hg.mozilla.org/mozilla-central/rev/d34e52a93da4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.