Change dimension's input field to type=number so I can use the mousewheel to decrease/increase
Categories
(DevTools :: Responsive Design Mode, enhancement, P2)
Tracking
(firefox68 fixed)
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: nachtigall, Assigned: bradwerth)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rdm-v2], [good first verify] )
Attachments
(3 files)
Updated•7 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
I'm not sure this even needs a test. I'll seek review as-is.
Assignee | ||
Updated•6 years ago
|
Comment 5•6 years ago
|
||
I don't think a test is necessary for a built-in input feature.
Assignee | ||
Comment 6•6 years ago
|
||
Victoria, we need a user experience judgment, please. It seems like we have two UX options:
- Keep the fields at width of 3em, and set the appearance to that of a textfield so no spinners are visible. This matches the current appearance of the fields, but gives the UI affordances like mousewheel adjustment.
- Adjust the fields to width of at least 4em, and show the spinners.
I've posted two screenshots of each option that show what this looks like with different numbers up to 4 digits.
Comment 7•6 years ago
|
||
(In reply to Brad Werth [:bradwerth] from comment #6)
Created attachment 9052092 [details]
3em vs 4em with spinners screenshots.zipVictoria, we need a user experience judgment, please. It seems like we have two UX options:
- Keep the fields at width of 3em, and set the appearance to that of a textfield so no spinners are visible. This matches the current appearance of the fields, but gives the UI affordances like mousewheel adjustment.
- Adjust the fields to width of at least 4em, and show the spinners.
I've posted two screenshots of each option that show what this looks like with different numbers up to 4 digits.
I think we went with #1 in new settings design implementation.
Comment 8•6 years ago
|
||
Thanks Brad for the screenshots - yep, #1 sounds good.
(For background, I did have something like #2 in my original plans, but the eventual consensus (lead by Martin/Razvan I believe) was that it looked overly hideous in Windows' native UI.)
Assignee | ||
Comment 9•6 years ago
|
||
(In reply to Victoria Wang [:victoria] from comment #8)
Thanks Brad for the screenshots - yep, #1 sounds good.
Okay, I've updated the patch to implement this. The fields are unchanged in size, but are number type and have textfield styling.
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
Backed out for failing dt at browser_device_width.js
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234855653&repo=autoland&lineNumber=5701
Backout: https://hg.mozilla.org/integration/autoland/rev/b29882123ec6753ce6292d1affec84669711d3bf
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
bugherder |
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Description
•