Closed Bug 1343030 Opened 3 years ago Closed 3 years ago

Intermittent stylo image/image-object-position-with-background-1.html | assertion count 1 is more than expected 0 assertions

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: gbrown)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file)

stylo-only

The assertion is

ASSERTION: Disagreement about whether it's a block or not: 'fromLine->IsBlock() == fromLine->mFirstChild->IsBlockOutside()', file /home/worker/workspace/build/src/layout/generic/nsBlockFrame.cpp, line 2877

This looks a lot like bug 1342342 (very similar, but different test name). I think https://hg.mozilla.org/integration/autoland/rev/3c8eff6b0d79bfc9c90ee66b718f6df636bc8354 may have shifted the problem.
Flags: needinfo?(gbrown)
Summary: Intermittent image/image-object-position-with-background-1.html | assertion count 1 is more than expected 0 assertions → Intermittent stylo image/image-object-position-with-background-1.html | assertion count 1 is more than expected 0 assertions
Flags: needinfo?(gbrown)
See Also: → 1342188
:emilio - I noticed https://bugzilla.mozilla.org/show_bug.cgi?id=1342188#c1. Is it surprising to still be seeing this assertion (now in a different test)?
Flags: needinfo?(emilio+bugs)
Yeah, that comment was wrong, I just couldn't reproduce locally, but after those patches landed that assertion still appears even for that test case (which is disabled now).

That assertion seems still active, and we need to figure out why :/.

Thanks for pinging though! :)

I have it on the radar, though I'm busy with a bunch of other stuff too.
Flags: needinfo?(emilio+bugs)
Whiteboard: [stockwell needswork]
Thanks for the clarification :emilio.

Since this fails frequently, I'd like to do something to suppress the failures unless a fix for the root cause will be available soon. Skipping the test just seems to "move" the assertion to the next test, but allowing the assertion seems to result in a green run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdf4a7d36578df6d676b54000cf8bb27ef2df051
Attachment #8843303 - Flags: review?(emilio+bugs)
Attachment #8843303 - Flags: review?(emilio+bugs) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcf89da3a9c0
Modify stylo reftest assert expectations for image-object-position-with-background-1.html; r=emilio
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell fixed]
Keywords: assertion
Priority: -- → P3
No longer blocks: stylo-bustage
It seems this has been fixed.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Assignee: nobody → gbrown
You need to log in before you can comment on or make changes to this bug.