Open Bug 1343063 Opened 8 years ago Updated 3 years ago

Sync client name isn't regenerated after restoring from backup

Categories

(Firefox for iOS :: Sync, defect)

Product:
Firefox for iOS
Component:
Sync
Platform:
All
iOS
Type:
defect

Tracking

()

People

(Reporter: rfeeley, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [MobileCore])

I recently upgraded my iPhone, restoring from a back-up via USB, and noticed that my iPhone name has not assumed the latest device name. STEPS TO REPRODUCE 1. Use Sync on Firefox for iOS 2. Take note of how the device name appears in Synced Tabs 3. Upgrade iOS device hardware, restore from back-up EXPECTED RESULTS - Device name is new device name (e.g. iPhone SE) ACTUAL RESULTS - Device name is old device name (e.g. iPhone 5S)
Not very familiar with the iOS side of things, but this seems like "as designed" behaviour to me that we should consider changing. Since you've restored the phone, you'll have the same profile as before, and thus the same client name. Getting to your desired behaviour would include changing client's name on user's behalf if we detect that it'll be different based on how we currently generate it. We should be careful to ensure that it's a stable name (e.g. won't change on an OS update..). We don't have user-accessible UI for this like we do on Android, so it seems like we don't need to worry that we'll be overwriting a custom name.
The client name is persisted: https://github.com/mozilla-mobile/firefox-ios/blob/f23c201ea0d2d93b86d2c44926adc091589df5ff/Sync/State.swift#L354 after being initially generated: https://github.com/mozilla-mobile/firefox-ios/blob/dae882fbadd4e467f7a6e4f04007528931fffddc/Shared/DeviceInfo.swift#L43 A solution for this bug should bear in mind Bug 1151336 -- for example, the right approach might be to simply reset Sync after detecting a restore, in which case we'll regenerate the client name and this bug will be magically fixed. Ryan: you might notice that you can restore the same backup to multiple devices; that will currently kinda screw things up. Bug 1151336 addresses that.
Depends on: 1151336
Hardware: Other → All
Summary: Old iOS device name appearing in Sync → Sync client name isn't regenerated after restoring from backup
Whiteboard: [MobileCore][FxA]
Whiteboard: [MobileCore][FxA] → [MobileCore]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.