Closed Bug 1343122 Opened 7 years ago Closed 7 years ago

When viewing a request's query string, multiple parameters with the same name are ignored except for the last occurance

Categories

(DevTools :: Netmonitor, defect, P1)

54 Branch
x86
macOS
defect

Tracking

(firefox53 verified, firefox54 verified)

VERIFIED FIXED
Firefox 54
Iteration:
54.3 - Mar 6
Tracking Status
firefox53 --- verified
firefox54 --- verified

People

(Reporter: emceeaich, Assigned: gasolin)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [netmonitor-reserve])

Attachments

(2 files)

Steps to reproduce:

* Go to https://emceeaich.github.io/triage-report/
* Hit F12 or right-click to inspect element 
* Go to Network tab to inspect one of the XHR tagged requests
* Note that the request includes `&product=Core&product=Firefox&product=Firefox for Android&product=Firefox for iOS&product=Toolkit` in the query string
* Click on `Params` tab
* Observe there's only one `component` parameter, `Toolkit`, listed in that tab

See attachment

Expected result

* a `component` parameter for each occurrence in the query string

Version: Nightly 54.0a1 (2017-02-23) (64-bit) MacOS
Flags: qe-verify?
Whiteboard: [netmonitor][triage]
Looks like a similar issue in Bug 1337015 - show multiple select params correctly
Assignee: nobody → gasolin
Comment on attachment 8842701 [details]
Bug 1343122 - support multiple params with the same name;

https://reviewboard.mozilla.org/r/116458/#review118122

LGTM!

R+

Honza
Attachment #8842701 - Flags: review?(odvarko) → review+
Status: NEW → ASSIGNED
Flags: qe-verify? → qe-verify+
Priority: -- → P1
Whiteboard: [netmonitor][triage] → [netmonitor]
thanks!

Like previous one, I'll set approval request for aurora
Keywords: checkin-needed
Comment on attachment 8842701 [details]
Bug 1343122 - support multiple params with the same name;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1317650
[User impact if declined]: The query params with same name will be shown incorrectly
[Is this code covered by automated tests?]: N
[Has the fix been verified in Nightly?]: N
[Needs manual test from QE? If yes, steps to reproduce]: Yes, follow the bug report 
[List of other uplifts needed for the feature/fix]: N
[Is the change risky?]: N
[Why is the change risky/not risky?]: The change only affect query params with same name
[String changes made/needed]: N
Attachment #8842701 - Flags: approval-mozilla-aurora?
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ece3e5e5f0f0
support multiple params with the same name;r=Honza
Keywords: checkin-needed
Iteration: --- → 54.3 - Mar 6
QA Contact: ciprian.georgiu
Whiteboard: [netmonitor] → [netmonitor-reserve]
https://hg.mozilla.org/mozilla-central/rev/ece3e5e5f0f0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8842701 [details]
Bug 1343122 - support multiple params with the same name;

Minor dev tools fix, ok to uplift to aurora 53.
Attachment #8842701 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I've reproduced the issue described in comment 0 using an affected build: Firefox Nightly 54.0a1 (Build Id: 20170223030204).
I have verified that the issue is not reproducible using 54.0a1 (Build Id:20170305030210) and using 53.0a2 (Build Id:20170306004003) on Mac 10.11.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.