Closed
Bug 1343128
Opened 7 years ago
Closed 7 years ago
stylo: Don't leave stale change hints and other restyle data hanging around in reconstructed subtrees
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
dbaron pointed out in the meeting today that we should make sure we handle this. Looks like we don't, but it's an easy fix assuming try is cooperative.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4510ac771b354ec4a0a6427394a9e0dd6459703
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #1) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=a4510ac771b354ec4a0a6427394a9e0dd6459703 Looks like this excluded some jobs (see bug 1340911 comment 4). Here's the rest: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95237cf0f8cbd2208fbd9d94dad5cf34f5494ae2 This is green. Uploading patch and flagging for review.
Assignee | ||
Comment 3•7 years ago
|
||
MozReview-Commit-ID: 4BIvC6lPUmF
Attachment #8842109 -
Flags: review?(emilio+bugs)
Comment 4•7 years ago
|
||
Comment on attachment 8842109 [details] [diff] [review] Don't leave stale change hints and other restyle data hanging around in reconstructed subtrees. v1 Review of attachment 8842109 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/base/ServoRestyleManager.h @@ +98,2 @@ > */ > + static void ClearRestyleStateFromSubtree(Element* aElement); Given we no longer call this from other places, perhaps we should move it back to the cpp file only? Anyway, we should really try to get the frame constructor to do this work on its way down the tree.
Attachment #8842109 -
Flags: review?(emilio+bugs) → review+
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/086f36cc278f Don't leave stale change hints and other restyle data hanging around in reconstructed subtrees. r=emilio
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/086f36cc278f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•