1343162 - stylo: Crash [@ nsLayoutUtils::ComputeBSizeValue mozilla::SizeComputationInput::ComputeBSizeValue mozilla::ReflowInput::ComputeMinMaxValues mozilla::ReflowInput::InitConstraints mozilla::ReflowInput::Init]

Status: RESOLVED FIXED

(Core :: General, defect, P1)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

found via bughunter and reproduced on latest stylo debug build from tinderbox

STR:
-> Load http://www.tfl.gov.uk
---> Crash

Bobby, this might be related to Bug 1342862 (just that bughunter found this on a topsite during testing) but you said there it should be fixed on m-c (and so on this tinderbox stylo build from taskcluster). Could you take a look ?

Comment 1

[Bobby Holley (:bholley)]

I was under the impression that this would be fixed by bug 1342710. Manish, any thoughts?

Comment 2

[Manish Goregaokar [:manishearth]]

I initially thought this was due to width/height being missed by that bug, but that was intentional -- we don't support kw values for w/h yet.

I have to get a new build to try this. In the meantime -- xidorn, have any ideas?

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

I did a stylo build with the current m-c, and I failed to reproduce the crash mentioned in comment 0, because it crashes for a different assertion to me:
> thread '<unnamed>' panicked at 'Caller should apply sibling hints', stylo\servo\components\style\data.rs:235
> stack backtrace:
>    0:     0x7ffba552d4ea - std::panicking::default_hook::{{closure}}
>                         at C:\bot\slave\stable-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:354
>    1:     0x7ffba552c756 - std::panicking::default_hook
>                         at C:\bot\slave\stable-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:365
>    2:     0x7ffba553104d - std::panicking::rust_panic_with_hook
>                         at C:\bot\slave\stable-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:553
>    3:     0x7ffba50937ad - std::panicking::begin_panic<&str>
>                         at C:\bot\slave\stable-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:515
>    4:     0x7ffba51d617a - style::data::{{impl}}::from
>                         at C:\mozilla-source\stylo\servo\components\style\data.rs:235
>    5:     0x7ffba543370e - core::convert::{{impl}}::into<style::restyle_hints::RestyleHint,style::data::StoredRestyleHint>
>                         at C:\bot\slave\stable-dist-rustc-win-msvc-64\build\src\libcore\convert.rs:271
>    6:     0x7ffba54cb602 - geckoservo::glue::Servo_NoteExplicitHints
>                         at stylo\servo\ports\geckolib\glue.rs:1244

Comment 4

[Emilio Cobos Álvarez (:emilio)]

With my patch in bug 1340334 this no longer reproduces.

Comment 5

[Chris Peterson [:cpeterson]]

Resolving as fixed by bug 1340334 per Emilio's comment 4.