Add-ons manager .button-link links move on focus

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Themes
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: dao, Assigned: Tony, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla54
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
Affected are for instance the "More" links in the extensions and themes views. This can be reproduced on Linux, probably not on Windows, not sure about macOS.

To fix this, we need to remove this rule:

https://hg.mozilla.org/mozilla-central/annotate/32dcdde1fc64fc39a9065dc4218265dbc727673f/toolkit/themes/shared/extensions/extensions.inc.css#l1013
(Reporter)

Updated

6 months ago
Assignee: nobody → tonyhjlee
(Assignee)

Comment 1

6 months ago
Just for confirmation, is the expected bug behaviour such that when on press of the more link, it moves slightly down?
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 2

6 months ago
No, it shouldn't move. Are you seeing this with or without a patch, and on what OS?
Flags: needinfo?(dao+bmo)
(Assignee)

Comment 3

6 months ago
(In reply to Dão Gottwald [:dao] from comment #2)
> No, it shouldn't move. Are you seeing this with or without a patch, and on
> what OS?

Ah, I forgot to pull recent changes. I'm on Linux Mint 18.1 on virtualbox. After rebuilding, I noticed that tab focusing on the more button links shifts it slightly as well as the title shifting slightly. After removing the particular css rule, the tab focusing no longer caused movement. I am wondering what steps to take from here.
(Reporter)

Comment 4

6 months ago
(In reply to Tony from comment #3)
> (In reply to Dão Gottwald [:dao] from comment #2)
> > No, it shouldn't move. Are you seeing this with or without a patch, and on
> > what OS?
> 
> Ah, I forgot to pull recent changes. I'm on Linux Mint 18.1 on virtualbox.
> After rebuilding, I noticed that tab focusing on the more button links
> shifts it slightly as well as the title shifting slightly.

Right, that's what this bug is about.

> After removing
> the particular css rule, the tab focusing no longer caused movement. I am
> wondering what steps to take from here.

Can you attach the patch removing that CSS rule?
(Reporter)

Comment 5

6 months ago
Just checked -- I can reproduce this bug on Windows too.
OS: Linux → All
(Assignee)

Comment 6

6 months ago
Created attachment 8843659 [details] [diff] [review]
bug-1343163-fix.patch

Sorry about the lateness.
Attachment #8843659 - Flags: review?(dao+bmo)
(Reporter)

Comment 7

6 months ago
Comment on attachment 8843659 [details] [diff] [review]
bug-1343163-fix.patch

Looks good!
Attachment #8843659 - Flags: review?(dao+bmo) → review+

Comment 8

6 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/376d3e4d4a75
Remove stray .button-link focus rule. r=dao

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/376d3e4d4a75
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.