1343238 - Dropdown for setting default addressbook directory not selected/focused after accesskey used

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Latest Thunderbird 54.0a1 + 53.0a2 on Windows 8.1

1. Go to Options > Compose > Addressing.
2. Press Alt + S to select the dropdown for the default directory when the address book gets opened.
Actual result: It doesn't have focus.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1343238 - Dropdown for setting default addressbook directory should be focused after accesskey used.

Review commit: https://reviewboard.mozilla.org/r/116028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116028/

Comment 2

[:aceman]

Comment on attachment 8841998 [details]
Bug 1343238 - Dropdown for setting default addressbook directory should be focused after accesskey used.

https://reviewboard.mozilla.org/r/116028/#review117544

Thanks.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8841998 [details]
Bug 1343238 - Dropdown for setting default addressbook directory should be focused after accesskey used.

This needs uplift to where we broke it.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8841998 [details]
Bug 1343238 - Dropdown for setting default addressbook directory should be focused after accesskey used.

https://reviewboard.mozilla.org/r/116028/#review117610

Comment 5

[:aceman]

We didn't exactly broke anything. This is polish for a new feature introduced in 53.

Comment 6

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/d5445bc2de975968c8beeb7cd1ec1a1633b201d3

Comment 7

[Jorg K (CEST = GMT+2)]

Aurora (TB 53):
https://hg.mozilla.org/releases/comm-aurora/rev/35afa7d9c7029425d8d34a610429ff976256f82c
Sorry, we didn't break anything, this is additional polish.