Closed
Bug 1343301
Opened 7 years ago
Closed 7 years ago
disable non-e10s Stylo tests because we will disable all non-e10s tests in 57
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla55
People
(Reporter: kmoir, Assigned: kmoir)
References
Details
Attachments
(1 file, 3 obsolete files)
1.56 KB,
patch
|
Details | Diff | Splinter Review |
from today's quantum meeting -> jmaher advised to turn off non-e10s Stylo tests because we will disable all non-e10s tests in 57
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → kmoir
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8842123 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8843358 -
Flags: review?(dustin)
Updated•7 years ago
|
Attachment #8843358 -
Flags: review?(dustin) → review+
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb3bfd49e641 disable non-e10s Stylo tests because we will disable all non-e10s tests in 57 r=dustin DONTBUILD
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b87d42837f revert Bug 1343301 - disable non-e10s Stylo tests because we will disable all non-e10s tests in 57 r=dustin DONTBUILD
Assignee | ||
Comment 5•7 years ago
|
||
That didn't work, it disabled all the reftests for stylo, including e10s. Not sure why, investigating. In the interim I have reverted the patch.
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d7f4f3e5fde disable non-e10s Stylo tests because we will disable all non-e10s tests in 57 r=me
Assignee | ||
Comment 7•7 years ago
|
||
Trying this patch now. Difficult to test on try.
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1574d9c42753 disable non-e10s Stylo tests because we will disable all non-e10s tests in 57 r=me
Assignee | ||
Comment 9•7 years ago
|
||
This fixed the issues on inbound, will see if it runs the correct set of tests on other branches as it is uplifted.
Attachment #8843358 -
Attachment is obsolete: true
Attachment #8844005 -
Attachment is obsolete: true
Assignee | ||
Comment 10•7 years ago
|
||
jmaher: does this requirement extend to turning off non-e10s tests that are not reftests?
Flags: needinfo?(jmaher)
Comment 11•7 years ago
|
||
talos will need to be shut off for non-e10s (well I think added for e10s only since it isn't defined yet), stylo reftests seem valuable in both non-e10s and e10s configurations. Are there specific concerns on a suite?
Flags: needinfo?(jmaher)
Assignee | ||
Comment 12•7 years ago
|
||
This was asked for in the Quantum developer productivity meeting last week jmaher suggests: we turn off non-e10s Stylo tests because we will disable all non-e10s tests in 57. reduce Talos frequency to once daily. https://docs.google.com/document/d/1AZI2tBjKGPvZ_ay2X6PQkwEML2PmhuWi12Vow1yWPN0/edit I'm working on enabling talos but haven't got it working yet.
Assignee | ||
Comment 13•7 years ago
|
||
Verified that only e10s reftests run on the branches specified. Will ask in quantum developer productivity meeting if non-e10s non-reftests should be disabled as well.
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7d7f4f3e5fde https://hg.mozilla.org/mozilla-central/rev/1574d9c42753
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Comment 15•7 years ago
|
||
reopening because I may need to disable more non-e10s non reftest tests, will ask in quantum meeting today
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 16•7 years ago
|
||
consensus was in meeting to leave other tests on so will close this bug
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Comment hidden (typo) |
Comment hidden (typo) |
Comment hidden (typo) |
Comment hidden (typo) |
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•