1343302 - Explicitly pass the nsHttpChannel to mCacheOpenRunnable instead of using a closure

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

This breaks the analysis which I'm trying to land on central in bug 1336510.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Explicitly pass the nsHttpChannel to mCacheOpenRunnable instead of using a closure

MozReview-Commit-ID: 2jPiUdI1DWN

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8842094 [details] [diff] [review]
Explicitly pass the nsHttpChannel to mCacheOpenRunnable instead of using a closure

Review of attachment 8842094 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ +8685,3 @@
>      mCacheOpenDelay = 0;
> +    mCacheOpenFunc(this);
> +    mCacheOpenFunc = nullptr;

Try this instead so we avoid any potential reentracy issues:
std::function<void(nsHttpChannel*)> localFunction = nullptr;
std::swap(localFunction, mCacheOpenFunc);
localFunction(this); // This will call AsyncOpenURI triggering the cache fetch

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Explicitly pass the nsHttpChannel to mCacheOpenRunnable instead of using a closure

MozReview-Commit-ID: 2jPiUdI1DWN

Comment 4

[Nika Layzell [:nika] (ni? for response)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c92dc508b3b50cbf159b6470254d7b4291daf111

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c92dc508b3b5